You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@apache.org> on 2007/08/06 16:21:59 UTC
[jira] Created: (CLI-142) CLI Parser is not very extension friendly
CLI Parser is not very extension friendly
-----------------------------------------
Key: CLI-142
URL: https://issues.apache.org/jira/browse/CLI-142
Project: Commons CLI
Issue Type: Improvement
Components: CLI-1.x
Affects Versions: 1.1
Reporter: Henning Schmiedehausen
Attachments: parser.patch
The Parser class is not really extension friendly.
- cmd is private, should either be protected or have a getter/setter pair
- options and requiredOptions should have getter/setters (requiredOptions depends on options)
- processProperties is private, should be protected
- processOptions is private, should be protected
-
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLI-142) CLI Parser is not very extension
friendly
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519699 ]
Henning Schmiedehausen commented on CLI-142:
--------------------------------------------
Legacy application, got it to work with that hack. I might consider moving to CLI 2 in the near future, for now, that patch did the trick for me.
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.2
>
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLI-142) CLI Parser is not very extension
friendly
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519682 ]
Henri Yandell commented on CLI-142:
-----------------------------------
It all seemed rather unextendable to me. Have you looked at CLI2, and do you have any thoughts on whether that looks more extendable?
I backed away from making things more extensible rather quickly in CLI1 when I hit bits like that, seemed like a lot of backwards compat issues just waiting to happen.
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.2
>
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLI-142) CLI Parser is not very extension friendly
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated CLI-142:
---------------------------------------
Priority: Minor (was: Major)
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Priority: Minor
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CLI-142) CLI Parser is not very extension friendly
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed CLI-142.
-----------------------------
Resolution: Fixed
Now 1.1 is out, applying this patch as it looks good.
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.2
>
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLI-142) CLI Parser is not very extension friendly
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated CLI-142:
---------------------------------------
Attachment: parser.patch
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLI-142) CLI Parser is not very extension friendly
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated CLI-142:
------------------------------
Fix Version/s: 1.2
Consider for 1.2; or mark as WONTFIX if 2.0 looks to be better designed for this.
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.2
>
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLI-142) CLI Parser is not very extension
friendly
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLI-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517946 ]
Henning Schmiedehausen commented on CLI-142:
--------------------------------------------
BTW: If you are looking for an use case, here it is:
I have a dynamic Task executor, that has a fixed set of options (list, info, run) and loads an additional set of options depending on the service name given as an argument to list/info/run. So as soon as one of these three has been encountered, I use processOptions to dynamically query the task in question about its options and add it to the running parser.
(And I do it over JMX, hence I need serializable classes. ;-) )
> CLI Parser is not very extension friendly
> -----------------------------------------
>
> Key: CLI-142
> URL: https://issues.apache.org/jira/browse/CLI-142
> Project: Commons CLI
> Issue Type: Improvement
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Henning Schmiedehausen
> Attachments: parser.patch
>
>
> The Parser class is not really extension friendly.
> - cmd is private, should either be protected or have a getter/setter pair
> - options and requiredOptions should have getter/setters (requiredOptions depends on options)
> - processProperties is private, should be protected
> - processOptions is private, should be protected
> -
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.