You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2020/04/30 17:53:22 UTC

[geode] branch feature/GEODE-8020b updated: debugging

This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch feature/GEODE-8020b
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-8020b by this push:
     new 5a66aa5  debugging
5a66aa5 is described below

commit 5a66aa5999691be290d1708437ef038c1f9365cc
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Thu Apr 30 10:52:32 2020 -0700

    debugging
---
 .../distributed/internal/ClusterDistributionManager.java    |  4 ++--
 .../main/java/org/apache/geode/internal/net/BufferPool.java |  8 ++++----
 .../java/org/apache/geode/internal/net/NioSslEngine.java    |  2 ++
 .../main/java/org/apache/geode/internal/tcp/Connection.java | 13 +++++++++----
 .../java/org/apache/geode/internal/tcp/MsgStreamerList.java |  1 +
 5 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
index 022fa59..184ea11 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
@@ -609,8 +609,8 @@ public class ClusterDistributionManager implements DistributionManager {
     if (member != getDistributionManagerId()) {
       String relationship = areInSameZone(getDistributionManagerId(), member) ? "" : "not ";
       Object[] logArgs = new Object[] {member, relationship};
-      logger.info("Member {} is {} equivalent or in the same redundancy zone.",
-          logArgs);
+      logger.info("Member {} is {}equivalent or in the same redundancy zone.",
+          logArgs, relationship);
     }
   }
 
diff --git a/geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java b/geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java
index 80a09a7..821ade8 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java
@@ -92,7 +92,7 @@ public class BufferPool {
         } else if (bb.capacity() >= size) {
           bb.rewind();
           bb.limit(size);
-//          logger.warn("BRUCE: acquiring pooled buffer {} hash {}", bb, Integer.toHexString(System.identityHashCode(bb)));
+          logger.warn("BRUCE: acquiring pooled buffer {} hash {}", bb, Integer.toHexString(System.identityHashCode(bb)));
 
           return bb;
         } else {
@@ -111,8 +111,8 @@ public class BufferPool {
         ref = bufferQueue.poll();
       }
       result = ByteBuffer.allocateDirect(size);
-//      logger.warn("BRUCE: allocating new pooled buffer {} hash {}", result, Integer.toHexString(System.identityHashCode(result)));
-//      logger.warn("BRUCE: ", new Exception("stack trace"));
+      logger.warn("BRUCE: allocating new pooled buffer {} hash {}", result, Integer.toHexString(System.identityHashCode(result)));
+      logger.warn("BRUCE: ", new Exception("stack trace"));
     } else {
       // if we are using heap buffers then don't bother with keeping them around
       result = ByteBuffer.allocate(size);
@@ -236,7 +236,7 @@ public class BufferPool {
   private void releaseBuffer(ByteBuffer bb, boolean send) {
     if (bb.isDirect()) {
       BBSoftReference bbRef = new BBSoftReference(bb, send);
-//      logger.warn("BRUCE: releasing pooled buffer {} hash {}", bb, Integer.toHexString(System.identityHashCode(bb)));
+      logger.warn("BRUCE: releasing pooled buffer {} hash {}", bb, Integer.toHexString(System.identityHashCode(bb)));
       bufferQueue.offer(bbRef);
     } else {
       if (send) {
diff --git a/geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java b/geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
index d948ae7..684b22e 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
@@ -269,6 +269,8 @@ public class NioSslEngine implements NioFilter {
 
     peerAppData.limit(peerAppData.capacity());
     while (wrappedBuffer.hasRemaining()) {
+//      logger.warn("BRUCE: unwrapping buffer {} hash {}",
+//          wrappedBuffer, Integer.toHexString(System.identityHashCode(wrappedBuffer)));
       SSLEngineResult unwrapResult = engine.unwrap(wrappedBuffer, peerAppData);
       switch (unwrapResult.getStatus()) {
         case BUFFER_OVERFLOW:
diff --git a/geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java b/geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
index 1723e09..0c6692e 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
@@ -1595,7 +1595,9 @@ public class Connection implements Runnable {
           }
           int amountRead;
           if (!isInitialRead) {
+            String bufferString = buff.toString();
             amountRead = channel.read(buff);
+            logger.info("BRUCE: read {} bytes into {} which is now {}", amountRead, bufferString, buff);
           } else {
             isInitialRead = false;
             if (!skipInitialRead) {
@@ -1861,6 +1863,8 @@ public class Connection implements Runnable {
       originalState = connectionState;
       connectionState = STATE_SENDING;
     }
+    logger.info("BRUCE: sendPreserialized writing {} hash {} to {} on local port {} remote port {}",
+        buffer, Integer.toHexString(System.identityHashCode(buffer)), remoteAddr, socket.getLocalPort(), socket.getPort());
     socketInUse = true;
     try {
       SocketChannel channel = getSocket().getChannel();
@@ -2729,9 +2733,10 @@ public class Connection implements Runnable {
     try {
       peerDataBuffer = ioFilter.unwrap(inputBuffer);
     } catch (SSLException e) {
-//      if (e.getMessage().contains("bad record MAC")) {
-//        logger.warn("BRUCE: exception unwrapping buffer {} hash {}", inputBuffer, Integer.toHexString(System.identityHashCode(inputBuffer)));
-//      }
+      if (e.getMessage().contains("bad record MAC")) {
+        logger.warn("BRUCE: exception unwrapping buffer {} hash {} socket.isclosed {}",
+            inputBuffer, Integer.toHexString(System.identityHashCode(inputBuffer)), this.socket.isClosed());
+      }
       throw e;
     }
     peerDataBuffer.flip();
@@ -3171,7 +3176,7 @@ public class Connection implements Runnable {
     Thread.currentThread().setName(THREAD_KIND_IDENTIFIER + " for " + remoteAddr + " "
         + (sharedResource ? "" : "un") + "shared" + " " + (preserveOrder ? "" : "un")
         + "ordered" + " uid=" + uniqueId + (dominoNumber > 0 ? " dom #" + dominoNumber : "")
-        + " port=" + socket.getPort());
+        + " local port=" + socket.getLocalPort() + " remote port=" + socket.getPort());
   }
 
   private void compactOrResizeBuffer(int messageLength) {
diff --git a/geode-core/src/main/java/org/apache/geode/internal/tcp/MsgStreamerList.java b/geode-core/src/main/java/org/apache/geode/internal/tcp/MsgStreamerList.java
index 08b573c..396d56e 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/tcp/MsgStreamerList.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/tcp/MsgStreamerList.java
@@ -39,6 +39,7 @@ public class MsgStreamerList implements BaseMsgStreamer {
   private final List<MsgStreamer> streamers;
 
   MsgStreamerList(List<MsgStreamer> streamers) {
+    logger.fatal("BRUCE: someone created a MsgStreamerList!", new Exception("stack trace"));
     this.streamers = streamers;
   }