You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/28 07:00:16 UTC

[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #9958: fix #9953

CrazyHZM commented on code in PR #9958:
URL: https://github.com/apache/dubbo/pull/9958#discussion_r860548706


##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java:
##########
@@ -239,7 +240,7 @@ public String getLogMessage() {
 
         Object[] args = get(ARGUMENTS) != null ? (Object[]) get(ARGUMENTS) : null;
         if (args != null && args.length > 0) {
-            sn.append(JSON.toJSONString(args));
+            sn.append(JSON.toJSONString(args, SerializerFeature.IgnoreErrorGetter));

Review Comment:
   Ignoring this property is not the best way. It is recommended to print an exception once to solve the problem of continuously filling the queue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org