You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/05/12 22:22:51 UTC
Review Request 21328: Fixed concurrent wait within the ExternalContainerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21328/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository: mesos-git
Description
-------
The ECP must not receive multiple, concurrent wait-invocations on the same ContainerID.
This fix checks if a wait-invocation is already active by checking if the wait-PID is setup (isSome). If that is the case, the EC simply returns the future of the termination without additionally invoking the ECP.
Diffs
-----
src/slave/containerizer/external_containerizer.cpp e51ac66
Diff: https://reviews.apache.org/r/21328/diff/
Testing
-------
make
Thanks,
Till Toenshoff
Re: Review Request 21328: Fixed concurrent wait within the
ExternalContainerizer.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21328/#review42747
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On May 12, 2014, 1:22 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21328/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 1:22 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The ECP must not receive multiple, concurrent wait-invocations on the same ContainerID.
>
> This fix checks if a wait-invocation is already active by checking if the wait-PID is setup (isSome). If that is the case, the EC simply returns the future of the termination without additionally invoking the ECP.
>
>
> Diffs
> -----
>
> src/slave/containerizer/external_containerizer.cpp e51ac66
>
> Diff: https://reviews.apache.org/r/21328/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Till Toenshoff
>
>