You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/08 05:58:47 UTC

[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19587: chore: cleanup as unknown conversion

zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845760699


##########
superset-frontend/packages/superset-ui-core/src/color/utils.ts:
##########
@@ -75,7 +75,16 @@ export function getAnalogousColors(colors: string[], results: number) {
 }
 
 export function addAlpha(color: string, opacity: number): string {
-  // coerce values so ti is between 0 and 1.

Review Comment:
   bycatch: fix codes coverage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org