You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2018/02/02 07:46:56 UTC

Review Request 65476: Add PartitionPolicy to config summary when defined

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/
-----------------------------------------------------------

Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.


Repository: aurora


Description
-------

Add PartitionPolicy to config summary when defined


Diffs
-----

  ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 


Diff: https://reviews.apache.org/r/65476/diff/1/


Testing
-------

Testing in vagrant (see screenshot).


File Attachments
----------------

Screen Shot 2018-02-01 at 11.46.17 PM.png
  https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png


Thanks,

David McLaughlin


Re: Review Request 65476: Add PartitionPolicy to config summary when defined

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196695
-----------------------------------------------------------



Master (21a371c) is red with this patch.
  ./build-support/jenkins/build.sh

                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                     --------------- Captured log call ----------------
                     health_checker.py          143 WARNING   WARN] Health check failure: failure
                     health_checker.py          184 WARNING   WARN] Ignoring failure of attempt: 1
                     health_checker.py          143 WARNING   WARN] Health check failure: failure
                     health_checker.py          184 WARNING   WARN] Ignoring failure of attempt: 2
                     health_checker.py          143 WARNING   WARN] Health check failure: failure
                     health_checker.py          159 WARNING   WARN] Reached consecutive failure limit.
                      1 failed, 799 passed, 6 skipped in 258.85 seconds 
                     
FAILURE


               Waiting for background workers to finish.
08:18:41 04:50   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 2, 2018, 7:46 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2018, 7:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> -------
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 65476: Add PartitionPolicy to config summary when defined

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196699
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Feb. 2, 2018, 8:46 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2018, 8:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> -------
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 65476: Add PartitionPolicy to config summary when defined

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196700
-----------------------------------------------------------



@ReviewBot retry

- Stephan Erb


On Feb. 2, 2018, 8:46 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2018, 8:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> -------
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 65476: Add PartitionPolicy to config summary when defined

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Feb. 2, 2018, 10:06 a.m., Aurora ReviewBot wrote:
> > Master (21a371c) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                       WARN] Reached consecutive failure limit.
> >                      --------------- Captured log call ----------------
> >                      health_checker.py          167 INFO      INFO] Reached consecutive success limit.
> >                      health_checker.py          143 WARNING   WARN] Health check failure: failure-2
> >                      health_checker.py          184 WARNING   WARN] Ignoring failure of attempt: 2
> >                      health_checker.py          143 WARNING   WARN] Health check failure: failure-3
> >                      health_checker.py          159 WARNING   WARN] Reached consecutive failure limit.
> >                       5 failed, 795 passed, 6 skipped in 368.28 seconds 
> >                      
> > FAILURE
> > 
> > 
> >                Waiting for background workers to finish.
> > 10:06:03 06:47   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

I'm randomly getting this failure locally too. Does anyone have an idea what change was introduced that caused this? Should we mark the test as skippable until it's triaged?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196702
-----------------------------------------------------------


On Feb. 2, 2018, 7:46 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2018, 7:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> -------
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 65476: Add PartitionPolicy to config summary when defined

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196702
-----------------------------------------------------------



Master (21a371c) is red with this patch.
  ./build-support/jenkins/build.sh

                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                      WARN] Reached consecutive failure limit.
                     --------------- Captured log call ----------------
                     health_checker.py          167 INFO      INFO] Reached consecutive success limit.
                     health_checker.py          143 WARNING   WARN] Health check failure: failure-2
                     health_checker.py          184 WARNING   WARN] Ignoring failure of attempt: 2
                     health_checker.py          143 WARNING   WARN] Health check failure: failure-3
                     health_checker.py          159 WARNING   WARN] Reached consecutive failure limit.
                      5 failed, 795 passed, 6 skipped in 368.28 seconds 
                     
FAILURE


               Waiting for background workers to finish.
10:06:03 06:47   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 2, 2018, 7:46 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2018, 7:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> -------
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 65476: Add PartitionPolicy to config summary when defined

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196713
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Feb. 1, 2018, 11:46 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2018, 11:46 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> -------
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>