You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Arnaud Lacombe (JIRA)" <ji...@apache.org> on 2017/04/04 22:51:41 UTC
[jira] [Commented] (THRIFT-4167) Missing compile flag
[ https://issues.apache.org/jira/browse/THRIFT-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956005#comment-15956005 ]
Arnaud Lacombe commented on THRIFT-4167:
----------------------------------------
the following patch fixes the build:
From da73fc6c66ffce709a74d3f03cceb06333ee5eae Mon Sep 17 00:00:00 2001
From: Arnaud Lacombe <al...@aerilon.ca>
Date: Tue, 4 Apr 2017 12:10:20 -0700
Subject: [PATCH] build
---
build/cmake/DefinePlatformSpecifc.cmake | 2 ++
1 file changed, 2 insertions(+)
diff --git a/build/cmake/DefinePlatformSpecifc.cmake b/build/cmake/DefinePlatformSpecifc.cmake
index e57ecc2..86010b0 100644
--- a/build/cmake/DefinePlatformSpecifc.cmake
+++ b/build/cmake/DefinePlatformSpecifc.cmake
@@ -82,6 +82,8 @@ if(WITH_BOOSTTHREADS)
add_definitions("-DUSE_BOOST_THREAD=1")
elseif(WITH_STDTHREADS)
add_definitions("-DUSE_STD_THREAD=1")
+ set(CMAKE_CXX_STANDARD 11)
+ set(CMAKE_CXX_STANDARD_REQUIRED ON)
endif()
# GCC and Clang.
> Missing compile flag
> --------------------
>
> Key: THRIFT-4167
> URL: https://issues.apache.org/jira/browse/THRIFT-4167
> Project: Thrift
> Issue Type: Bug
> Reporter: Arnaud Lacombe
>
> While trying to build the following on ubuntu 16.04:
> # cmake -DBUILD_COMPILER=ON -DBUILD_LIBRARIES=ON -DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF -DWITH_CPP=ON -DWITH_BOOST_STATIC=ON -DWITH_STDTHREADS=ON ..
> the build dies on the following:
> In file included from /usr/include/c++/5/thread:35:0,
> from /tmp/thrift/lib/cpp/src/thrift/concurrency/Thread.h:32,
> from /tmp/thrift/lib/cpp/src/thrift/concurrency/ThreadManager.h:26,
> from /build_tmp/thrift/lib/cpp/src/thrift/concurrency/ThreadManager.cpp:22:
> /usr/include/c++/5/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
> #error This file requires compiler and library support
> [...]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)