You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2021/12/15 05:02:00 UTC
[jira] [Commented] (IGNITE-15867) Socket shutdown called twice in GridNioServer

    [ https://issues.apache.org/jira/browse/IGNITE-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459659#comment-17459659 ] 

Ignite TC Bot commented on IGNITE-15867:
----------------------------------------

{panel:title=Branch: [pull/9651/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9651/head] Base: [master] : New Tests (32)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Basic 1{color} [[tests 2|https://ci.ignite.apache.org/viewLog.html?buildId=6323197]]
* {color:#013220}IgniteBasicTestSuite: GridNioServerTest.shouldNotLogWarningsOnKeyClose - PASSED{color}
* {color:#013220}IgniteBasicTestSuite: IgniteUtilsUnitTest.shouldNotProduceWarningsWhenClosingAnAlreadyClosedSocket - PASSED{color}

{color:#00008b}PDS 2{color} [[tests 30|https://ci.ignite.apache.org/viewLog.html?buildId=6323256]]
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testReadBeforeGracefulShutdown[specificConsistentId=false, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testReReadWhenStateWasNotStored[specificConsistentId=false, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testMultiNodeConsumption[specificConsistentId=false, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testCdcSingleton[specificConsistentId=false, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testReReadWhenStateWasNotStored[specificConsistentId=true, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testMultiNodeConsumption[specificConsistentId=true, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testCdcSingleton[specificConsistentId=true, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testReadAllKeys[specificConsistentId=false, walMode=FSYNC, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testReReadWhenStateWasNotStored[specificConsistentId=true, walMode=BACKGROUND, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testMultiNodeConsumption[specificConsistentId=true, walMode=BACKGROUND, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
* {color:#013220}IgnitePdsTestSuite2: CdcSelfTest.testCdcSingleton[specificConsistentId=true, walMode=BACKGROUND, metricExporter=org.apache.ignite.cdc.CdcSelfTest$$Lambda$17/264767425@5dd903be] - PASSED{color}
... and 19 new tests

{panel}
[TeamCity *--&gt; Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=6323282&amp;buildTypeId=IgniteTests24Java8_RunAll]

> Socket shutdown called twice in GridNioServer
> ---------------------------------------------
>
>                 Key: IGNITE-15867
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15867
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 2.11
>            Reporter: Ilya Korol
>            Assignee: Roman Puchkovskiy
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After fixing IGNITE-15367 calling {{GridNioServer$AbstractNioClientWorker.closekey(SelectionKey key)}} would produce excessive {{java.nio.channels.ClosedChannelException}} because {{sock.shutdownInput()}} and {{sock.shutdownInput()}} would be called twice:
> {code:java}
> // GridNioServer$AbstractNioClientWorker
> private void closeKey(SelectionKey key) {
>     // Shutdown input and output so that remote client will see correct socket close.
>     Socket sock = ((SocketChannel)key.channel()).socket();
>     try {
>         try {
>             sock.shutdownInput();           // <-- First time
>         }
>         catch (IOException ignored) {
>             // No-op.
>         }
>         try {
>             sock.shutdownOutput();          // <-- First time
>         }
>         catch (IOException ignored) {
>             // No-op.
>         }
>     }
>     finally {
>         U.close(key, log);                  // <-- Second time
>         U.close(sock, log);                 // <-- Second time
>     }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)