You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/09/19 01:12:25 UTC
[kudu-CR] [util] info on sent/received if Blocking{Recv,Write} timed out
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16475
Change subject: [util] info on sent/received if Blocking{Recv,Write} timed out
......................................................................
[util] info on sent/received if Blocking{Recv,Write} timed out
This patch adds information on the number of requested and actually
sent/received bytes into the return status of Socket::BlockingRecv()
and Socket::BlockingWrite() methods in case of operation times out.
The motivation for this patch is to help in troubleshooting of
connection negotiation issues.
Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
---
M src/kudu/util/net/socket.cc
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/16475/1
--
To view, visit http://gerrit.cloudera.org:8080/16475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] info on sent/received if Blocking{Recv,Write} timed out
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16475 )
Change subject: [util] info on sent/received if Blocking{Recv,Write} timed out
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16475/1/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:
http://gerrit.cloudera.org:8080/#/c/16475/1/src/kudu/util/net/socket.cc@469
PS1, Line 469: return Status::TimedOut(Substitute("sent $0 of $1 requested bytes",
> nit: Should the messages still indicate there was a timeout even though the
The generated message for Status::TimedOut() contains that information already. In this case it would look like:
Timed out: sent xxx of yyy requested bytes
--
To view, visit http://gerrit.cloudera.org:8080/16475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Oct 2020 15:16:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] info on sent/received if Blocking{Recv,Write} timed out
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16475 )
Change subject: [util] info on sent/received if Blocking{Recv,Write} timed out
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16475/1/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:
http://gerrit.cloudera.org:8080/#/c/16475/1/src/kudu/util/net/socket.cc@469
PS1, Line 469: return Status::TimedOut(Substitute("sent $0 of $1 requested bytes",
nit: Should the messages still indicate there was a timeout even though the status is TimedOut?
--
To view, visit http://gerrit.cloudera.org:8080/16475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:33:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] info on sent/received if Blocking{Recv,Write} timed out
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16475 )
Change subject: [util] info on sent/received if Blocking{Recv,Write} timed out
......................................................................
[util] info on sent/received if Blocking{Recv,Write} timed out
This patch adds information on the number of requested and actually
sent/received bytes into the return status of Socket::BlockingRecv()
and Socket::BlockingWrite() methods in case of operation times out.
The motivation for this patch is to help in troubleshooting of
connection negotiation issues.
Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Reviewed-on: http://gerrit.cloudera.org:8080/16475
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/util/net/socket.cc
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] info on sent/received if Blocking{Recv,Write} timed out
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16475 )
Change subject: [util] info on sent/received if Blocking{Recv,Write} timed out
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Oct 2020 15:17:45 +0000
Gerrit-HasComments: No