You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/26 00:12:28 UTC

[GitHub] [incubator-echarts] WillPower98 opened a new pull request #13482: feat(tooltip): added marker options. close #13413

WillPower98 opened a new pull request #13482:
URL: https://github.com/apache/incubator-echarts/pull/13482


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ x ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Adds a new feature to adjust tooltip radius, height, and width.
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: 13413
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   There should be a configuration option for the tooltip marker size.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   radius: "10px",
   height: "10px",
   width: "10px"
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on pull request #13482: feat(tooltip): added marker options. close #13413

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13482:
URL: https://github.com/apache/incubator-echarts/pull/13482#issuecomment-716240415


   Take it easy. You are welcome to do this. We appreciate any forms of contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] WillPower98 closed pull request #13482: feat(tooltip): added marker options. close #13413

Posted by GitBox <gi...@apache.org>.
WillPower98 closed pull request #13482:
URL: https://github.com/apache/incubator-echarts/pull/13482


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] WillPower98 commented on pull request #13482: feat(tooltip): added marker options. close #13413

Posted by GitBox <gi...@apache.org>.
WillPower98 commented on pull request #13482:
URL: https://github.com/apache/incubator-echarts/pull/13482#issuecomment-716239720


   > Hi, thanks a lot for your first contribution!
   > 
   > We only need to commit the changed source files which are in the src directory. It's unnecessary to commit the distribution files which are in the dist directory. And it would be better if some test cases can be provided.
   > 
   > Please make some changes to this pull request accordingly. Thank you.
   
   I will do this. Sorry it's my first time doing these things.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart edited a comment on pull request #13482: feat(tooltip): added marker options. close #13413

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #13482:
URL: https://github.com/apache/incubator-echarts/pull/13482#issuecomment-716240415


   Take it easy. You are welcome to do this. We appreciate any form of contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org