You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jmschrack <gi...@git.apache.org> on 2014/12/12 05:18:35 UTC
[GitHub] spark pull request: Added "--package" argument to make-distributio...
GitHub user jmschrack opened a pull request:
https://github.com/apache/spark/pull/3682
Added "--package" argument to make-distribution.sh
"--package" creates a distribution without building.
Added the above info to the README.md.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmschrack/spark branch-1.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3682.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3682
----
commit d70028057c71f98a742bacf6893f7ccf6d942919
Author: Jonathan Schrack <jm...@gmail.com>
Date: 2014-12-12T04:15:26Z
Added "--package" argument to make-distribution.sh to create a distribution without building.
Added the above info to the README.md.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added "--package" argument to make-distributio...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3682#issuecomment-66730770
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added "--package" argument to make-distributio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3682
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added "--package" argument to make-distributio...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3682#issuecomment-69637083
Hey @jmschrack - I'm not sure we want to allow packaging without building in this script. This allows for some confusing outcomes, such as a user compiles Spark for one version, then they call `make-distribution` with different maven flags, and the naming of the distribution and notes are inconsistent with the actual binaries. Since make-distribution takes identical flags to the build, I'd rather just force people to build and package atomically. So I'd prefer to close this issue for now and feel free to re-open if you'd like to discuss further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org