You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/02 18:03:05 UTC

[GitHub] [pulsar] rdhabalia opened a new pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

rdhabalia opened a new pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108


   ### Motivation
   Right now, Bundle split task considers max-session count on topic to split bundle and in some usecases, we want to disable this threshold-check because some usecases have expected number of high producer/consumer connection and we don't want to split based on this criteria. so, provide a way to disable this check by setting -1 value which skips the threshold check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#discussion_r762758088



##########
File path: conf/broker.conf
##########
@@ -1080,6 +1080,7 @@ loadBalancerAutoUnloadSplitBundlesEnabled=true
 loadBalancerNamespaceBundleMaxTopics=1000
 
 # maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered
+# (disable threshold check with value -1)

Review comment:
       @rdhabalia for the doc side, there are 2 `loadBalancerNamespaceBundleMaxSessions` in the [Pulsar configuration page](https://pulsar.apache.org/docs/en/next/reference-configuration/#broker), need to add the explanations for both?
   
   ![image](https://user-images.githubusercontent.com/50226895/144805266-fcc3fe7c-cd84-4766-b8fc-4600f803ce47.png)
   
   
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#discussion_r761645318



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1915,6 +1915,7 @@
     @FieldContext(
         category = CATEGORY_LOAD_BALANCER,
         doc = "maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered"
+                + "(disable threshold check with value -1)"

Review comment:
       nit:
   ```suggestion
                   + " (disable threshold check with value -1)"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rdhabalia commented on a change in pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
rdhabalia commented on a change in pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#discussion_r772615023



##########
File path: conf/broker.conf
##########
@@ -1080,6 +1080,7 @@ loadBalancerAutoUnloadSplitBundlesEnabled=true
 loadBalancerNamespaceBundleMaxTopics=1000
 
 # maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered
+# (disable threshold check with value -1)

Review comment:
       yes, these config are not related to this change and already exist, but will create a separate PR to address documentation concerns.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#discussion_r776905627



##########
File path: conf/broker.conf
##########
@@ -1080,6 +1080,7 @@ loadBalancerAutoUnloadSplitBundlesEnabled=true
 loadBalancerNamespaceBundleMaxTopics=1000
 
 # maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered
+# (disable threshold check with value -1)

Review comment:
       Hi @rdhabalia any updates on the docs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#issuecomment-984868342


   @rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#discussion_r769847483



##########
File path: conf/broker.conf
##########
@@ -1080,6 +1080,7 @@ loadBalancerAutoUnloadSplitBundlesEnabled=true
 loadBalancerNamespaceBundleMaxTopics=1000
 
 # maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered
+# (disable threshold check with value -1)

Review comment:
       @rdhabalia - will you be able to update this documentation? If not, I still think we should merge this PR and maybe someone can follow up with a PR to update the docs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rdhabalia merged pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
rdhabalia merged pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13108: [pulsar-broker] load-balancer support disabling max-session for bundle split

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13108:
URL: https://github.com/apache/pulsar/pull/13108#discussion_r772899804



##########
File path: conf/broker.conf
##########
@@ -1080,6 +1080,7 @@ loadBalancerAutoUnloadSplitBundlesEnabled=true
 loadBalancerNamespaceBundleMaxTopics=1000
 
 # maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered
+# (disable threshold check with value -1)

Review comment:
       Hi @rdhabalia do not forget to update docs, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org