You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/22 17:13:02 UTC

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #488: [YUNIKORN-1500] Remove periodic state dump support

codecov[bot] commented on PR #488:
URL: https://github.com/apache/yunikorn-core/pull/488#issuecomment-1363116154

   # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#488](https://codecov.io/gh/apache/yunikorn-core/pull/488?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bedc6d6) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/0b47b404ec432dfb699e13d01d58936650ae4d0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b47b40) will **decrease** coverage by `0.16%`.
   > The diff coverage is `42.85%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #488      +/-   ##
   ==========================================
   - Coverage   73.23%   73.07%   -0.17%     
   ==========================================
     Files          69       69              
     Lines       10497    10371     -126     
   ==========================================
   - Hits         7688     7579     -109     
   + Misses       2555     2544      -11     
   + Partials      254      248       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/scheduler/partition.go](https://codecov.io/gh/apache/yunikorn-core/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `76.93% <ø> (-0.23%)` | :arrow_down: |
   | [pkg/webservice/state\_dump.go](https://codecov.io/gh/apache/yunikorn-core/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `70.00% <33.33%> (-9.48%)` | :arrow_down: |
   | [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/yunikorn-core/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `84.69% <50.00%> (-1.93%)` | :arrow_down: |
   | [pkg/scheduler/objects/sorters.go](https://codecov.io/gh/apache/yunikorn-core/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3NvcnRlcnMuZ28=) | `97.00% <0.00%> (+1.79%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org