You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/25 07:45:15 UTC
Review Request 46622: Added tests for flag aliases.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added tests for flag aliases.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46622/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46622: Added tests for flag aliases.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/#review131246
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (line 52)
<https://reviews.apache.org/r/46622/#comment195146>
Especially since the previous patch alters the behavior of `usage()`, it would be nice to include a flag with an alias in `TestFlags`, so that the usage output can be checked in the relevant tests cases.
- Greg Mann
On April 30, 2016, 3:43 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46622/
> -----------------------------------------------------------
>
> (Updated April 30, 2016, 3:43 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for flag aliases.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
>
> Diff: https://reviews.apache.org/r/46622/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 46622: Added tests for flag aliases.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/
-----------------------------------------------------------
(Updated April 30, 2016, 3:43 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added tests for flag aliases.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46622/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46622: Added tests for flag aliases.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/
-----------------------------------------------------------
(Updated April 29, 2016, 3:26 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
tests update.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added tests for flag aliases.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46622/diff/
Testing
-------
make check
Thanks,
Vinod Kone