You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/25 09:49:43 UTC
[GitHub] [skywalking-java] wankai123 opened a new pull request #37: Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
wankai123 opened a new pull request #37:
URL: https://github.com/apache/skywalking-java/pull/37
### Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [X] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
related to https://github.com/apache/skywalking/issues/7135
clean up `operationId` because not use anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #37: Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #37:
URL: https://github.com/apache/skywalking-java/pull/37#issuecomment-927097424
You missed UT parts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #37: Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-java/pull/37#discussion_r716042753
##########
File path: CHANGES.md
##########
@@ -28,6 +28,7 @@ Release Notes.
* Implement Kafka Log Reporter. Add config item of `agnt.conf`, `plugin.kafka.topic_logging`.
* Upgrade byte-buddy to 1.11.18
* Add plugin to support Apache HttpClient 5.
+* Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Review comment:
@wankai123 You missed my second one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #37: Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #37:
URL: https://github.com/apache/skywalking-java/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #37: Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-java/pull/37#discussion_r716020038
##########
File path: CHANGES.md
##########
@@ -28,6 +28,7 @@ Release Notes.
* Implement Kafka Log Reporter. Add config item of `agnt.conf`, `plugin.kafka.topic_logging`.
* Upgrade byte-buddy to 1.11.18
* Add plugin to support Apache HttpClient 5.
+* Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Review comment:
```suggestion
* Format SpringMVC & Tomcat EntrySpan operation name to `METHOD:URI`
* Make `HTTP method` in the operation name according to runtime, rather than previous code-level definition, which used to have possibilities including multiple HTTP methods.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #37: Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #37:
URL: https://github.com/apache/skywalking-java/pull/37#discussion_r716020038
##########
File path: CHANGES.md
##########
@@ -28,6 +28,7 @@ Release Notes.
* Implement Kafka Log Reporter. Add config item of `agnt.conf`, `plugin.kafka.topic_logging`.
* Upgrade byte-buddy to 1.11.18
* Add plugin to support Apache HttpClient 5.
+* Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI`
Review comment:
```suggestion
* Format SpringMVC & Tomcat EntrySpan operation name to `METHOD:URI`
* Make `method name` in new operation name according to runtime, rather than previous code-level definition, which used to have possibilities including multiple HTTP methods.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org