[GitHub] [pinot] 61yao commented on a diff in pull request #10514: [WIP]: 10513 - Null support in Case/When queries.

["61yao (via GitHub)" <gi...@apache.org>]

61yao commented on code in PR #10514:
URL: https://github.com/apache/pinot/pull/10514#discussion_r1161179130


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -49,6 +50,10 @@ static RexExpression toRexExpression(RexNode rexNode) {
     } else if (rexNode instanceof RexLiteral) {
       RexLiteral rexLiteral = ((RexLiteral) rexNode);
       FieldSpec.DataType dataType = RelToStageConverter.convertToFieldSpecDataType(rexLiteral.getType());
+      //Added to set the DataType as UNKNOWN

Review Comment:
   This is v2 engine code. @walterddr should have a better understanding of this. My code only deals with v1 path. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org