You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/08 16:28:00 UTC

[jira] [Commented] (METRON-1025) Metron github pr template should not reference incubator

    [ https://issues.apache.org/jira/browse/METRON-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079215#comment-16079215 ] 

ASF GitHub Bot commented on METRON-1025:
----------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/640

    METRON-1025 remove incubator from github pr template

    The pr template should not contain 'incubator' any longer.
    
    ### to test 
    checkout this pr and push to your git repo, create a pr on that branch
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron metron_github_template_incubator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #640
    
----
commit 569d9b77dc0d1f89680333e9a8b8871782e4e780
Author: Otto Fowler <ot...@gmail.com>
Date:   2017-07-08T16:23:32Z

    remove incubator

----


> Metron github pr template should not reference incubator
> --------------------------------------------------------
>
>                 Key: METRON-1025
>                 URL: https://issues.apache.org/jira/browse/METRON-1025
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>
> It does though



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)