You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/11 18:38:00 UTC
[GitHub] [ozone] GeorgeJahad commented on a diff in pull request #3786: HDDS-7281. [Snapshot] Handle RocksDB compaction DAG persistence and reconstruction
GeorgeJahad commented on code in PR #3786:
URL: https://github.com/apache/ozone/pull/3786#discussion_r992663448
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -262,57 +336,34 @@ public void onCompactionCompleted(
e.printStackTrace();
}
}
+ sb.append('\n');
+
LOG.warn("List of output files:");
for (String file : compactionJobInfo.outputFiles()) {
+ final String fn = file.substring(filenameBegin + 1);
+ sb.append(fn).append('\t');
LOG.warn(file + ",");
}
- // Let us also build the graph
- for (String outFilePath : compactionJobInfo.outputFiles()) {
- String outfile =
- Paths.get(outFilePath).getFileName().toString();
- CompactionNode outfileNode = compactionNodeTable.get(outfile);
- if (outfileNode == null) {
- long numKeys = 0;
- try {
- numKeys = getSSTFileSummary(outfile);
- } catch (Exception e) {
- LOG.warn(e.getMessage());
- }
- outfileNode = new CompactionNode(outfile,
- lastSnapshotPrefix, numKeys,
- currentCompactionGen);
- compactionDAGFwd.addNode(outfileNode);
- compactionDAGReverse.addNode(outfileNode);
- compactionNodeTable.put(outfile, outfileNode);
- }
- for (String inFilePath : compactionJobInfo.inputFiles()) {
- String infile =
- Paths.get(inFilePath).getFileName().toString();
- CompactionNode infileNode = compactionNodeTable.get(infile);
- if (infileNode == null) {
- long numKeys = 0;
- try {
- numKeys = getSSTFileSummary(infile);
- } catch (Exception e) {
- LOG.warn(e.getMessage());
- }
- infileNode = new CompactionNode(infile,
- lastSnapshotPrefix,
- numKeys, UNKNOWN_COMPACTION_GEN);
- compactionDAGFwd.addNode(infileNode);
- compactionDAGReverse.addNode(infileNode);
- compactionNodeTable.put(infile, infileNode);
- }
- if (outfileNode.fileName.compareToIgnoreCase(
- infileNode.fileName) != 0) {
- compactionDAGFwd.putEdge(outfileNode, infileNode);
- compactionDAGReverse.putEdge(infileNode, outfileNode);
- }
- }
- }
- if (debugEnabled(DEBUG_DAG_BUILD_UP)) {
- printMutableGraph(null, null, compactionDAGFwd);
+ sb.append('\n');
+
+ // Persist infile/outfile to file
+ try (BufferedWriter bw = Files.newBufferedWriter(
+ Paths.get(CURRENT_COMPACTION_LOG_FILENAME),
Review Comment:
If I'm understanding things correctly, everything else persisted in rocksdb. But these compaction log files have a separate format. That isn't necessarily a bad thing, but I'm curious about your thinking. Why are the compaction logs persisted in their own set of files instead of rocksdb?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org