You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sarutak <gi...@git.apache.org> on 2018/08/28 17:49:32 UTC

[GitHub] spark pull request #22258: [SPARK-25266] Fix memory leak vulnerability in Ba...

GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/22258

    [SPARK-25266] Fix memory leak vulnerability in Barrier Execution Mode

    ## What changes were proposed in this pull request?
    
    BarrierCoordinator$ uses Timer and TimerTask. `TimerTask#cancel()` is invoked in ContextBarrierState#cancelTimerTask but `Timer#purge()` is never invoked.
    
    Once a TimerTask is scheduled, the reference to it is not released until `Timer#purge()` is invoked even though `TimerTask#cancel()` is invoked.
    
    ## How was this patch tested?
    
    I checked the number of instances related to the TimerTask using jmap.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark fix-barrierexec-oom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22258
    
----
commit 15039741fa25ca6a6a8df5e887351789be28f49e
Author: sarutak <sa...@...>
Date:   2018-08-28T17:06:11Z

    Fixed OOM issue in Barrier Execution Mode

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2637/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    **[Test build #95396 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95396/testReport)** for PR 22258 at commit [`1503974`](https://github.com/apache/spark/commit/15039741fa25ca6a6a8df5e887351789be28f49e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Ex...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22258


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    **[Test build #95396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95396/testReport)** for PR 22258 at commit [`1503974`](https://github.com/apache/spark/commit/15039741fa25ca6a6a8df5e887351789be28f49e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95396/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    **[Test build #95372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95372/testReport)** for PR 22258 at commit [`1503974`](https://github.com/apache/spark/commit/15039741fa25ca6a6a8df5e887351789be28f49e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2654/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    LGTM pending test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Can you remove vulnerability from the title? Otherwise it sounds like a security vulnerability here.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    **[Test build #95372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95372/testReport)** for PR 22258 at commit [`1503974`](https://github.com/apache/spark/commit/15039741fa25ca6a6a8df5e887351789be28f49e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak in Barrier Execution Mode

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    All right. It's done.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266][CORE] Fix memory leak in Barrier Execution...

Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Merged into master. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95372/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22258: [SPARK-25266] Fix memory leak vulnerability in Barrier E...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22258
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org