You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/31 07:33:12 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1152: tools/Makefiles: Fix use of unbuilt incdir binary

xiaoxiang781216 edited a comment on pull request #1152:
URL: https://github.com/apache/incubator-nuttx/pull/1152#issuecomment-636427076


   @patacongo Yes, it is better to put the logic into Makefile than refresh.sh, but we still need do some hack before invoke Makefile.host since Makefile.host also include Make.defs too. My question is that how much benefit we can get from the immediate varaible?
   https://github.com/apache/incubator-nuttx/pull/1150
   If the value isn't too huge, we can keep the delayed variable as before to simplify the logic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org