You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/07 09:32:19 UTC

[GitHub] [cordova-plugin-statusbar] timbru31 commented on a change in pull request #126: WIP: fix: remove deprecated platforms

timbru31 commented on a change in pull request #126: WIP: fix: remove deprecated platforms
URL: https://github.com/apache/cordova-plugin-statusbar/pull/126#discussion_r281548772
 
 

 ##########
 File path: plugin.xml
 ##########
 @@ -53,9 +53,7 @@
         </js-module>
     </platform>
 
-    <!-- ios -->
 
 Review comment:
   Yeah I know... would like to omit the discussion regarding comments and if the are a code smell or not, when a comment is fine, ... 😅 - but in this case it's pretty what to expect from `<platform name="ios">`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org