You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by sujith71955 <gi...@git.apache.org> on 2016/09/17 08:12:00 UTC

[GitHub] incubator-carbondata pull request #163: Problem:Column heading was missing i...

GitHub user sujith71955 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/163

    Problem:Column heading was missing in driver statistics table and sca\u2026

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
                     
    ---
    
    \u2026n block time was always zero in query statistics table.
    
    Analysis:While creating driver statistics table header was not created and the scan block time was not initialized before recording in statistics recorder.
    
    Fix:One more line is added to print the column header in driver statistics table and the scan block time is initialized before recording the statistics.
    
    Impact:Logs of all query

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sujith71955/incubator-carbondata statistics_recorder_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit 665978e937603fd85c55a64c656655705ca20f0d
Author: akashrn5 <ak...@huawei.com>
Date:   2016-09-17T07:03:31Z

    Problem:Column heading was missing in driver statistics table and scan block time was always zero in query statistics table.
    
    Analysis:While creating driver statistics table header was not created and the scan block time was not initialized before recording in statistics recorder.
    
    Fix:One more line is added to print the column header in driver statistics table and the scan block time is initialized before recording the statistics.
    
    Impact:Logs of all query

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #163: [CARBONDATA-248]Problem:Column headi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---