You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/01/23 12:46:06 UTC
[GitHub] incubator-brooklyn pull request: JS gui improvements - empty catal...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/466
JS gui improvements - empty catalog and server list
shows yaml tab (and nice message on catalog tab) if catalog is empty
server list is now after apps list, and there is a way to clear it (new `HighAvailabilityManagerImpl.publishClearNonMaster()` method, REST call, and button on main page)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn jsgui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit b5a15a99db067bf567184a05b4044df71b58d389
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-01-23T10:30:12Z
handle catalog empty better
if empty, switch to the yaml tab, and put a nice message with links in case the user comes back.
also use a throbber while loading.
commit 304e70861cb1a995233dcd1566ad3de0cdf27e51
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-01-23T10:32:07Z
switch apps and servers on jsgui home page
commit dfd8d575645e299dc0ed4db140487e362445eace
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-01-23T11:16:42Z
add support for clearing out stale/non-master management node records
included in GUI, which allows if you start to get a long list of old dead servers it is easy to clear them
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: JS gui improvements - empty catal...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/466#discussion_r23464462
--- Diff: api/src/main/java/brooklyn/management/ha/HighAvailabilityManager.java ---
@@ -97,7 +97,12 @@
void setPriority(long priority);
long getPriority();
-
+
+ /** deletes non-master node records; active nodes (including this) will republish,
+ * so this provides a simple way to clean out the cache of dead brooklyn nodes */
+ @Beta
+ void publishClearNonMaster();
--- End diff --
This feels like a strange method name. Why the two verbs of publish and clear?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: JS gui improvements - empty catal...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/466#issuecomment-71231160
When the catalog is empty, should I see "The applications catalog is empty" rather than just a white rectangle? I'm still just seeing the empty white rectangle in the add application, when I start with a catalog.xml of `<catalog/>`.
The other changes all work really well for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: JS gui improvements - empty catal...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: JS gui improvements - empty catal...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/466#issuecomment-71240294
you're right @aledsage -- fixed that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---