You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/02 05:41:31 UTC

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4790: Add administrative interface to invoker and controller to reconfigure runtimes

ningyougang commented on a change in pull request #4790:
URL: https://github.com/apache/openwhisk/pull/4790#discussion_r585276745



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ExecManifest.scala
##########
@@ -58,6 +58,20 @@ protected[core] object ExecManifest {
     mf
   }
 
+  /**
+   * Reads runtimes manifest from runtime string
+   *
+   * @param runtime
+   * @return the manifest if initialized successfully, or an failure
+   */
+  protected[core] def initialize(runtime: String): Try[Runtimes] = {

Review comment:
       Yes, you are right, updated accordingly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org