You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/08 10:34:21 UTC

[GitHub] [commons-numbers] aherbert commented on a change in pull request #104: Improvements:

aherbert commented on a change in pull request #104:
URL: https://github.com/apache/commons-numbers/pull/104#discussion_r684752808



##########
File path: commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java
##########
@@ -38,7 +38,7 @@
      *
      * @param numValues Number of values of the function to compute.
      * @param cache Cached values.
-     * @throw IllegalArgumentException if {@code n < 0}.
+     * @throw CombinatoricsException if {@code n < 0}.

Review comment:
       `CombinatoricsException` is package private; it should not be exposed in the javadoc. It extends IllegalArgumentException so the javadoc is still valid.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org