Moving email-related ocnfiguration to separate bean.

[Vladimir Ozerov <vo...@gridgain.com>]

Hi,

We have lots of properties in IgniteConfiguration dedicated to email setup:

setLifeCycleEmailNotification
setSmtpSsl
setSmtpStartTls
setSmtpHost
setSmtpPort
setSmtpUsername
setSmtpPassword
setAdminEmails
setSmtpFromEmail

It seems to me that all these properties are very rarely used, aren't they?
If so, how about moving them to separate bean to make IgniteConfiguration
lighter?

Vladimir.

Re: Moving email-related ocnfiguration to separate bean.

[Yakov Zhdanov <yz...@apache.org>]

Agree

--Yakov

2015-02-11 20:38 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:

> I think all the email functionality should be removed from Ignite. Such
> functionality really belongs in management and monitoring apps, not in our
> core components.
>
> Yakov, what do you think?
>
> D.
>
> On Wed, Feb 11, 2015 at 9:11 AM, Alexey Kuznetsov <akuznetsov@gridgain.com
> >
> wrote:
>
> > But we also use *sendAdminEmailAsync *in IgniteKernal.start().
> > Should it be also removed?
> >
> > On Wed, Feb 11, 2015 at 11:58 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org
> > >
> > wrote:
> >
> > > Then I would propose to configure it in Visor, not in Ignite. I still
> > vote
> > > for taking it out from Ignite and filling another ticket to add it to
> > > Visor.
> > >
> > > D.
> > >
> > > On Wed, Feb 11, 2015 at 7:46 AM, Alexey Kuznetsov <
> > akuznetsov@gridgain.com
> > > >
> > > wrote:
> > >
> > > > Commandline VisorAlertCommand use them.
> > > >
> > > >
> > > > On Wed, Feb 11, 2015 at 10:25 PM, Dmitriy Setrakyan <
> > > dsetrakyan@apache.org
> > > > >
> > > > wrote:
> > > >
> > > > > I don't think these settings are used anywhere in the project. Are
> > they
> > > > > used in the management console?
> > > > >
> > > > > D.
> > > > >
> > > > > On Wed, Feb 11, 2015 at 7:18 AM, Alexey Kuznetsov <
> > > > akuznetsov@gridgain.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > How about to implement e-mail notifications as a kind of plugin /
> > > some
> > > > > > pluggable service?
> > > > > >
> > > > > >
> > > > > > On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <
> > > > > dsetrakyan@apache.org
> > > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > I would remove it from Ignite altogether.
> > > > > > >
> > > > > > > On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <
> > > > vozerov@gridgain.com
> > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > We have lots of properties in IgniteConfiguration dedicated
> to
> > > > email
> > > > > > > setup:
> > > > > > > >
> > > > > > > > setLifeCycleEmailNotification
> > > > > > > > setSmtpSsl
> > > > > > > > setSmtpStartTls
> > > > > > > > setSmtpHost
> > > > > > > > setSmtpPort
> > > > > > > > setSmtpUsername
> > > > > > > > setSmtpPassword
> > > > > > > > setAdminEmails
> > > > > > > > setSmtpFromEmail
> > > > > > > >
> > > > > > > > It seems to me that all these properties are very rarely
> used,
> > > > aren't
> > > > > > > they?
> > > > > > > > If so, how about moving them to separate bean to make
> > > > > > IgniteConfiguration
> > > > > > > > lighter?
> > > > > > > >
> > > > > > > > Vladimir.
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > > GridGain Systems
> > > > > > www.gridgain.com
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > > GridGain Systems
> > > > www.gridgain.com
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>

Re: Moving email-related ocnfiguration to separate bean.

[Dmitriy Setrakyan <ds...@apache.org>]

I think all the email functionality should be removed from Ignite. Such
functionality really belongs in management and monitoring apps, not in our
core components.

Yakov, what do you think?

D.

On Wed, Feb 11, 2015 at 9:11 AM, Alexey Kuznetsov <ak...@gridgain.com>
wrote:

> But we also use *sendAdminEmailAsync *in IgniteKernal.start().
> Should it be also removed?
>
> On Wed, Feb 11, 2015 at 11:58 PM, Dmitriy Setrakyan <dsetrakyan@apache.org
> >
> wrote:
>
> > Then I would propose to configure it in Visor, not in Ignite. I still
> vote
> > for taking it out from Ignite and filling another ticket to add it to
> > Visor.
> >
> > D.
> >
> > On Wed, Feb 11, 2015 at 7:46 AM, Alexey Kuznetsov <
> akuznetsov@gridgain.com
> > >
> > wrote:
> >
> > > Commandline VisorAlertCommand use them.
> > >
> > >
> > > On Wed, Feb 11, 2015 at 10:25 PM, Dmitriy Setrakyan <
> > dsetrakyan@apache.org
> > > >
> > > wrote:
> > >
> > > > I don't think these settings are used anywhere in the project. Are
> they
> > > > used in the management console?
> > > >
> > > > D.
> > > >
> > > > On Wed, Feb 11, 2015 at 7:18 AM, Alexey Kuznetsov <
> > > akuznetsov@gridgain.com
> > > > >
> > > > wrote:
> > > >
> > > > > How about to implement e-mail notifications as a kind of plugin /
> > some
> > > > > pluggable service?
> > > > >
> > > > >
> > > > > On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <
> > > > dsetrakyan@apache.org
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > I would remove it from Ignite altogether.
> > > > > >
> > > > > > On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <
> > > vozerov@gridgain.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > We have lots of properties in IgniteConfiguration dedicated to
> > > email
> > > > > > setup:
> > > > > > >
> > > > > > > setLifeCycleEmailNotification
> > > > > > > setSmtpSsl
> > > > > > > setSmtpStartTls
> > > > > > > setSmtpHost
> > > > > > > setSmtpPort
> > > > > > > setSmtpUsername
> > > > > > > setSmtpPassword
> > > > > > > setAdminEmails
> > > > > > > setSmtpFromEmail
> > > > > > >
> > > > > > > It seems to me that all these properties are very rarely used,
> > > aren't
> > > > > > they?
> > > > > > > If so, how about moving them to separate bean to make
> > > > > IgniteConfiguration
> > > > > > > lighter?
> > > > > > >
> > > > > > > Vladimir.
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > > GridGain Systems
> > > > > www.gridgain.com
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

Re: Moving email-related ocnfiguration to separate bean.

[Alexey Kuznetsov <ak...@gridgain.com>]

But we also use *sendAdminEmailAsync *in IgniteKernal.start().
Should it be also removed?

On Wed, Feb 11, 2015 at 11:58 PM, Dmitriy Setrakyan <ds...@apache.org>
wrote:

> Then I would propose to configure it in Visor, not in Ignite. I still vote
> for taking it out from Ignite and filling another ticket to add it to
> Visor.
>
> D.
>
> On Wed, Feb 11, 2015 at 7:46 AM, Alexey Kuznetsov <akuznetsov@gridgain.com
> >
> wrote:
>
> > Commandline VisorAlertCommand use them.
> >
> >
> > On Wed, Feb 11, 2015 at 10:25 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org
> > >
> > wrote:
> >
> > > I don't think these settings are used anywhere in the project. Are they
> > > used in the management console?
> > >
> > > D.
> > >
> > > On Wed, Feb 11, 2015 at 7:18 AM, Alexey Kuznetsov <
> > akuznetsov@gridgain.com
> > > >
> > > wrote:
> > >
> > > > How about to implement e-mail notifications as a kind of plugin /
> some
> > > > pluggable service?
> > > >
> > > >
> > > > On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <
> > > dsetrakyan@apache.org
> > > > >
> > > > wrote:
> > > >
> > > > > I would remove it from Ignite altogether.
> > > > >
> > > > > On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <
> > vozerov@gridgain.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > We have lots of properties in IgniteConfiguration dedicated to
> > email
> > > > > setup:
> > > > > >
> > > > > > setLifeCycleEmailNotification
> > > > > > setSmtpSsl
> > > > > > setSmtpStartTls
> > > > > > setSmtpHost
> > > > > > setSmtpPort
> > > > > > setSmtpUsername
> > > > > > setSmtpPassword
> > > > > > setAdminEmails
> > > > > > setSmtpFromEmail
> > > > > >
> > > > > > It seems to me that all these properties are very rarely used,
> > aren't
> > > > > they?
> > > > > > If so, how about moving them to separate bean to make
> > > > IgniteConfiguration
> > > > > > lighter?
> > > > > >
> > > > > > Vladimir.
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > > GridGain Systems
> > > > www.gridgain.com
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>



-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Re: Moving email-related ocnfiguration to separate bean.

[Dmitriy Setrakyan <ds...@apache.org>]

Then I would propose to configure it in Visor, not in Ignite. I still vote
for taking it out from Ignite and filling another ticket to add it to Visor.

D.

On Wed, Feb 11, 2015 at 7:46 AM, Alexey Kuznetsov <ak...@gridgain.com>
wrote:

> Commandline VisorAlertCommand use them.
>
>
> On Wed, Feb 11, 2015 at 10:25 PM, Dmitriy Setrakyan <dsetrakyan@apache.org
> >
> wrote:
>
> > I don't think these settings are used anywhere in the project. Are they
> > used in the management console?
> >
> > D.
> >
> > On Wed, Feb 11, 2015 at 7:18 AM, Alexey Kuznetsov <
> akuznetsov@gridgain.com
> > >
> > wrote:
> >
> > > How about to implement e-mail notifications as a kind of plugin / some
> > > pluggable service?
> > >
> > >
> > > On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <
> > dsetrakyan@apache.org
> > > >
> > > wrote:
> > >
> > > > I would remove it from Ignite altogether.
> > > >
> > > > On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <
> vozerov@gridgain.com
> > >
> > > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > We have lots of properties in IgniteConfiguration dedicated to
> email
> > > > setup:
> > > > >
> > > > > setLifeCycleEmailNotification
> > > > > setSmtpSsl
> > > > > setSmtpStartTls
> > > > > setSmtpHost
> > > > > setSmtpPort
> > > > > setSmtpUsername
> > > > > setSmtpPassword
> > > > > setAdminEmails
> > > > > setSmtpFromEmail
> > > > >
> > > > > It seems to me that all these properties are very rarely used,
> aren't
> > > > they?
> > > > > If so, how about moving them to separate bean to make
> > > IgniteConfiguration
> > > > > lighter?
> > > > >
> > > > > Vladimir.
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

Re: Moving email-related ocnfiguration to separate bean.

[Alexey Kuznetsov <ak...@gridgain.com>]

Commandline VisorAlertCommand use them.


On Wed, Feb 11, 2015 at 10:25 PM, Dmitriy Setrakyan <ds...@apache.org>
wrote:

> I don't think these settings are used anywhere in the project. Are they
> used in the management console?
>
> D.
>
> On Wed, Feb 11, 2015 at 7:18 AM, Alexey Kuznetsov <akuznetsov@gridgain.com
> >
> wrote:
>
> > How about to implement e-mail notifications as a kind of plugin / some
> > pluggable service?
> >
> >
> > On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org
> > >
> > wrote:
> >
> > > I would remove it from Ignite altogether.
> > >
> > > On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <vozerov@gridgain.com
> >
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > We have lots of properties in IgniteConfiguration dedicated to email
> > > setup:
> > > >
> > > > setLifeCycleEmailNotification
> > > > setSmtpSsl
> > > > setSmtpStartTls
> > > > setSmtpHost
> > > > setSmtpPort
> > > > setSmtpUsername
> > > > setSmtpPassword
> > > > setAdminEmails
> > > > setSmtpFromEmail
> > > >
> > > > It seems to me that all these properties are very rarely used, aren't
> > > they?
> > > > If so, how about moving them to separate bean to make
> > IgniteConfiguration
> > > > lighter?
> > > >
> > > > Vladimir.
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>



-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Re: Moving email-related ocnfiguration to separate bean.

[Dmitriy Setrakyan <ds...@apache.org>]

I don't think these settings are used anywhere in the project. Are they
used in the management console?

D.

On Wed, Feb 11, 2015 at 7:18 AM, Alexey Kuznetsov <ak...@gridgain.com>
wrote:

> How about to implement e-mail notifications as a kind of plugin / some
> pluggable service?
>
>
> On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <dsetrakyan@apache.org
> >
> wrote:
>
> > I would remove it from Ignite altogether.
> >
> > On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <vo...@gridgain.com>
> > wrote:
> >
> > > Hi,
> > >
> > > We have lots of properties in IgniteConfiguration dedicated to email
> > setup:
> > >
> > > setLifeCycleEmailNotification
> > > setSmtpSsl
> > > setSmtpStartTls
> > > setSmtpHost
> > > setSmtpPort
> > > setSmtpUsername
> > > setSmtpPassword
> > > setAdminEmails
> > > setSmtpFromEmail
> > >
> > > It seems to me that all these properties are very rarely used, aren't
> > they?
> > > If so, how about moving them to separate bean to make
> IgniteConfiguration
> > > lighter?
> > >
> > > Vladimir.
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

Re: Moving email-related ocnfiguration to separate bean.

[Alexey Kuznetsov <ak...@gridgain.com>]

How about to implement e-mail notifications as a kind of plugin / some
pluggable service?


On Wed, Feb 11, 2015 at 10:14 PM, Dmitriy Setrakyan <ds...@apache.org>
wrote:

> I would remove it from Ignite altogether.
>
> On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <vo...@gridgain.com>
> wrote:
>
> > Hi,
> >
> > We have lots of properties in IgniteConfiguration dedicated to email
> setup:
> >
> > setLifeCycleEmailNotification
> > setSmtpSsl
> > setSmtpStartTls
> > setSmtpHost
> > setSmtpPort
> > setSmtpUsername
> > setSmtpPassword
> > setAdminEmails
> > setSmtpFromEmail
> >
> > It seems to me that all these properties are very rarely used, aren't
> they?
> > If so, how about moving them to separate bean to make IgniteConfiguration
> > lighter?
> >
> > Vladimir.
> >
>



-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Re: Moving email-related ocnfiguration to separate bean.

[Dmitriy Setrakyan <ds...@apache.org>]

I would remove it from Ignite altogether.

On Wed, Feb 11, 2015 at 7:07 AM, Vladimir Ozerov <vo...@gridgain.com>
wrote:

> Hi,
>
> We have lots of properties in IgniteConfiguration dedicated to email setup:
>
> setLifeCycleEmailNotification
> setSmtpSsl
> setSmtpStartTls
> setSmtpHost
> setSmtpPort
> setSmtpUsername
> setSmtpPassword
> setAdminEmails
> setSmtpFromEmail
>
> It seems to me that all these properties are very rarely used, aren't they?
> If so, how about moving them to separate bean to make IgniteConfiguration
> lighter?
>
> Vladimir.
>