[buildstream] 03/12: fetchqueue.py: Don't skip elements with a cached failure

[no...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

not-in-ldap pushed a commit to branch juerg/cache-query-job-benchmark
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit fb47c892f072fed1eb0870d5fc84ed88fec48276
Author: Jürg Billeter <j...@bitron.ch>
AuthorDate: Thu Sep 17 17:44:50 2020 +0200

    fetchqueue.py: Don't skip elements with a cached failure
    
    The build queue requires the sources to be available for all elements
    where `_cached_success()` returns `False`. This includes elements with a
    cached failure.
---
 src/buildstream/_scheduler/queues/fetchqueue.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/buildstream/_scheduler/queues/fetchqueue.py b/src/buildstream/_scheduler/queues/fetchqueue.py
index 18bf392..3a4183d 100644
--- a/src/buildstream/_scheduler/queues/fetchqueue.py
+++ b/src/buildstream/_scheduler/queues/fetchqueue.py
@@ -50,7 +50,7 @@ class FetchQueue(Queue):
             if not element._can_query_cache():
                 return QueueStatus.PENDING
 
-            if element._cached():
+            if element._cached_success():
                 return QueueStatus.SKIP
 
         # This will automatically skip elements which