You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/04/17 15:30:25 UTC
[GitHub] [ignite-3] AMashenkov opened a new pull request, #1948: IGNITE-19262 Sql. DDL silently ignores transaction
AMashenkov opened a new pull request, #1948:
URL: https://github.com/apache/ignite-3/pull/1948
https://issues.apache.org/jira/browse/IGNITE-19262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1948: IGNITE-19262 Sql. Throw exception on explicit TX with DDL
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #1948:
URL: https://github.com/apache/ignite-3/pull/1948#discussion_r1171424129
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -597,6 +597,32 @@ public void errors() {
await(ars.closeAsync());
assertThrowsWithCause(() -> await(ars.fetchNextPage()), CursorClosedException.class);
}
+
+ // DDL is non-transactional.
+ {
+ Transaction tx = igniteTx().begin();
+ try {
+ assertThrowsWithCause(() -> await(ses.executeAsync(tx, "CREATE TABLE TEST2(ID INT PRIMARY KEY, VAL0 INT)")),
+ SqlException.class,
+ "DDL doesn't support transactions."
+ );
+ } finally {
+ tx.rollback();
+ }
+ }
+ {
Review Comment:
it looks as a separate test :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1948: IGNITE-19262 Sql. Throw exception on explicit TX with DDL
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #1948:
URL: https://github.com/apache/ignite-3/pull/1948#discussion_r1170937702
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -597,6 +597,19 @@ public void errors() {
await(ars.closeAsync());
assertThrowsWithCause(() -> await(ars.fetchNextPage()), CursorClosedException.class);
}
+
+ // DDL is non-transactional.
Review Comment:
I would like an additional test when we do a few operations in the transaction and just after it calls DDL in the same TX. Check that transaction is not rolled back or committed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #1948: IGNITE-19262 Sql. Throw exception on explicit TX with DDL
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov merged PR #1948:
URL: https://github.com/apache/ignite-3/pull/1948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1948: IGNITE-19262 Sql. Throw exception on explicit TX with DDL
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #1948:
URL: https://github.com/apache/ignite-3/pull/1948#discussion_r1170940240
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -597,6 +597,19 @@ public void errors() {
await(ars.closeAsync());
assertThrowsWithCause(() -> await(ars.fetchNextPage()), CursorClosedException.class);
}
+
+ // DDL is non-transactional.
Review Comment:
Also, need to check that we have tests with DDL for auto-commit off and on in JDBC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org