You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2023/12/22 03:11:40 UTC

[PR] [pipelineX](refactor) rename functions [doris]

Gabriel39 opened a new pull request, #28846:
URL: https://github.com/apache/doris/pull/28846

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #28846:
URL: https://github.com/apache/doris/pull/28846


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28846:
URL: https://github.com/apache/doris/pull/28846#issuecomment-1867187056

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28846:
URL: https://github.com/apache/doris/pull/28846#issuecomment-1867187040

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #28846:
URL: https://github.com/apache/doris/pull/28846#issuecomment-1867181237

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #28846:
URL: https://github.com/apache/doris/pull/28846#discussion_r1434683147


##########
be/src/pipeline/exec/analytic_sink_operator.h:
##########
@@ -107,15 +107,15 @@ class AnalyticSinkOperatorX final : public DataSinkOperatorX<AnalyticSinkLocalSt
 
     Status sink(RuntimeState* state, vectorized::Block* in_block,
                 SourceState source_state) override;
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/partition_sort_sink_operator.h:
##########
@@ -105,9 +105,9 @@ class PartitionSortSinkOperatorX final : public DataSinkOperatorX<PartitionSortS
     Status open(RuntimeState* state) override;
     Status sink(RuntimeState* state, vectorized::Block* in_block,
                 SourceState source_state) override;
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -163,7 +163,7 @@ class HashJoinProbeOperatorX final : public JoinProbeOperatorX<HashJoinProbeLoca
                 SourceState& source_state) const override;
 
     bool need_more_input_data(RuntimeState* state) const override;
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/streaming_aggregation_sink_operator.h:
##########
@@ -120,7 +120,7 @@ class StreamingAggSinkOperatorX final : public AggSinkOperatorX<StreamingAggSink
     Status init(const TPlanNode& tnode, RuntimeState* state) override;
     Status sink(RuntimeState* state, vectorized::Block* in_block,
                 SourceState source_state) override;
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/nested_loop_join_build_operator.h:
##########
@@ -102,7 +102,7 @@ class NestedLoopJoinBuildSinkOperatorX final
     Status sink(RuntimeState* state, vectorized::Block* in_block,
                 SourceState source_state) override;
 
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/nested_loop_join_probe_operator.h:
##########
@@ -227,7 +227,7 @@ class NestedLoopJoinProbeOperatorX final
         return _old_version_flag ? _row_descriptor : *_intermediate_row_desc;
     }
 
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/assert_num_rows_operator.h:
##########
@@ -57,7 +57,7 @@ class AssertNumRowsOperatorX final : public StreamingOperatorX<AssertNumRowsLoca
 
     [[nodiscard]] bool is_source() const override { return false; }
 
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



##########
be/src/pipeline/exec/exchange_source_operator.h:
##########
@@ -117,7 +117,7 @@ class ExchangeSourceOperatorX final : public OperatorX<ExchangeLocalState> {
         return _sub_plan_query_statistics_recvr;
     }
 
-    DataDistribution get_local_exchange_type() const override {
+    DataDistribution required_data_distribution() const override {

Review Comment:
   warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataDistribution required_data_distribution() override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28846:
URL: https://github.com/apache/doris/pull/28846#issuecomment-1867212396

   TeamCity be ut coverage result:
    Function Coverage: 36.47% (8536/23405) 
    Line Coverage: 28.59% (69414/242753)
    Region Coverage: 27.61% (35917/130079)
    Branch Coverage: 24.36% (18360/75378)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/9ba1c303f7efe11ace8e34e7dbbdf42fcc222560_9ba1c303f7efe11ace8e34e7dbbdf42fcc222560/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](refactor) rename functions [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28846:
URL: https://github.com/apache/doris/pull/28846#issuecomment-1867247493

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.12 seconds
    stream load tsv:          582 seconds loaded 74807831229 Bytes, about 122 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.2 seconds inserted 10000000 Rows, about 354K ops/s
    storage size: 17184030624 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org