You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/10/24 20:21:36 UTC

[PR] chore(r/adbcsnowflake): Update adbcsnowflake such that it can be submitted to CRAN [arrow-adbc]

paleolimbot opened a new pull request, #1220:
URL: https://github.com/apache/arrow-adbc/pull/1220

   Closes #1067.
   
   - [x] Make it possible to run the tests locally
   - [x] Make sure the package builds after `go mod vendor`
   - [ ] Automate the vendoring into a script that can be run just before release
   - [ ] Find some way to host the bundled dependencies
   
   Some initial notes:
   
   Running `go mod vendor` + the build works *but* you need to copy some files from the repo to make sure that `cdata/arrow/c/abi.h` and `cdata/arrow/c/helpers.h` are available (they are not copied with `go mod vendor`). I also had to add `#include <assert.h>` to helpers.h (because `assert()` was undefined otherwise) and add the function definitions to `cdata/trampline.c` and remove the `inline` part of the definition. Neither @zeroshade nor I have no idea why any of this has to happen!
   
   With the vendored dependencies, the tarball is 13 MB, which is greater than CRAN's allowed 5 MB tarball size. This means a .zip file containing the vendored sources (or perhaps just the `src/go/vendor` directory) has to be hosted. On the mailing list thread where I asked how to do this in accordance with CRAN policy, Simon suggested Zenodo. I think the best option would be to just zip up the `vendor` directory after the release as a post-release packaging step and modify the `configure` scripts to download it (maybe from the artifactory like we do with the R arrow package static libraries). If the file ceases to exist at some point in the future, `go build` will happily build without the `vendor/` directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore(r/adbcsnowflake): Update adbcsnowflake such that it can be submitted to CRAN [arrow-adbc]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.

zeroshade commented on code in PR #1220:
URL: https://github.com/apache/arrow-adbc/pull/1220#discussion_r1375012536


##########
r/adbcsnowflake/src/Makevars.in:
##########
@@ -15,8 +15,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
-PKG_CPPFLAGS=-I$(CURDIR)/src -DADBC_EXPORT=""
-PKG_LIBS=-L$(CURDIR)/go -ladbc_driver_snowflake -lresolv @libs@

Review Comment:
   didn't we find that we needed `-lresolv` for macOS systems?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org