You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/04/29 23:53:58 UTC
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/34
CB-8930: Vibration on Windows fails without a helpful error message when
vibration functionality is missing from the platform. This detects such a
case and instead fails gracefully that the feature isn't available. Also
supports the Windows 10 vibration mechanism.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-vibration CB-8930
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-vibration/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit d6a741c6f2deababa2671d7b0e9c98b28a29f8a9
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-04-29T00:36:07Z
CB-8930: Vibration on Windows fails without a helpful error message when
vibration functionality is missing from the platform. This detects such a
case and instead fails gracefully that the feature isn't available. Also
supports the Windows 10 vibration mechanism.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/34#discussion_r29514735
--- Diff: plugin.xml ---
@@ -75,8 +75,12 @@
<runs />
</js-module>
+ <!--<config-file target="package.appxmanifest" versions=">=10.0.0" parent="/Package/Dependencies">
+ <TargetDeviceFamily MaxVersionTested="10.0.10050.0" MinVersion="10.0.10050.0" Name="Windows.Mobile" />
--- End diff --
Why is this comment here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/34#issuecomment-98177629
One minor comment - LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/34#issuecomment-98182104
Fixed, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/34#discussion_r29386717
--- Diff: src/windows/VibrationProxy.js ---
@@ -35,26 +35,74 @@ function tryDoAction(actionName, success, fail, args, action) {
}
action(args);
- success();
+ success && success();
--- End diff --
Proxy calls are always called with a valid success + fail callback function. No need for the extra checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org