You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by John Kordich via Review Board <no...@reviews.apache.org> on 2017/09/06 00:05:25 UTC
Review Request 62106: Enabled CRAM MD5 Authentication on Windows and
associated tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384
Repository: mesos
Description
-------
Enabled CRAM MD5 Authentication on Windows and associated tests.
Diffs
-----
cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
Diff: https://reviews.apache.org/r/62106/diff/1/
Testing
-------
Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
Thanks,
John Kordich
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184618
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62105, 62106]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 6, 2017, 12:05 a.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 12:05 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
>
>
> Diff: https://reviews.apache.org/r/62106/diff/1/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184725
-----------------------------------------------------------
cmake/CompilationConfigure.cmake
Lines 114-121 (original)
<https://reviews.apache.org/r/62106/#comment260915>
Yay!
docs/windows.md
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/62106/#comment260916>
We probably need to update `support/windows-build.bat` too.
src/CMakeLists.txt
Lines 619-622 (original), 615-623 (patched)
<https://reviews.apache.org/r/62106/#comment260917>
This might read better as an if/else.
src/authentication/cram_md5/authenticatee.cpp
Lines 21 (patched)
<https://reviews.apache.org/r/62106/#comment260919>
I admittedly personally prefer `#if defined(WIN32)`; however, AFAIK, we're explicitly using `#ifdef __WINDOWS__` and should stick to convention (until if/when we replace it).
NOTE: I definitely saw a couple uses of `#if defined(__WINDOWS__)` so perhaps this is already not a strict convention.
- Andrew Schwartzmeyer
On Sept. 6, 2017, 1:35 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 1:35 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
>
>
> Diff: https://reviews.apache.org/r/62106/diff/2/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Sept. 18, 2017, 12:42 p.m., Andrew Schwartzmeyer wrote:
> > src/master/master.cpp
> > Lines 494-605 (original), 494-587 (patched)
> > <https://reviews.apache.org/r/62106/diff/4/?file=1818635#file1818635line494>
> >
> > I believe this to be fine, and I briefly checked with Jie (I think) at MesosCon about this, but I'd like to make sure we get one more reviewer to make 100% sure we can remove the `HAS_AUTHENTICATION` definition. I'll get them added...
I can't edit your review. John, would you add Jie Yu as a reviewer?
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review185614
-----------------------------------------------------------
On Sept. 8, 2017, 3:13 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 3:13 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
> src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
> src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
> src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb
> support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
>
>
> Diff: https://reviews.apache.org/r/62106/diff/4/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review185614
-----------------------------------------------------------
src/CMakeLists.txt
Line 617 (original), 613-614 (patched)
<https://reviews.apache.org/r/62106/#comment261915>
Just an ordering suggestion: would you move `sasl2` up above the conditional libraries, maybe between `process` and `zookeeper`?
src/Makefile.am
Line 234 (original)
<https://reviews.apache.org/r/62106/#comment261918>
This is what confirms (at least for me) that we've not been supporting disabling this flag for a long time.
src/authentication/cram_md5/authenticatee.cpp
Line 21 (original), 21-25 (patched)
<https://reviews.apache.org/r/62106/#comment261916>
For this and the below, should we see if we can get the SASL build to put the headers under `include/sasl` instead of just `include` so that all this code change can go away?
src/master/master.cpp
Lines 494-605 (original), 494-587 (patched)
<https://reviews.apache.org/r/62106/#comment261917>
I believe this to be fine, and I briefly checked with Jie (I think) at MesosCon about this, but I'd like to make sure we get one more reviewer to make 100% sure we can remove the `HAS_AUTHENTICATION` definition. I'll get them added...
- Andrew Schwartzmeyer
On Sept. 8, 2017, 3:13 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 3:13 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
> src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
> src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
> src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb
> support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
>
>
> Diff: https://reviews.apache.org/r/62106/diff/4/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/
-----------------------------------------------------------
(Updated Sept. 8, 2017, 10:13 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
Changes
-------
Addressed new comments
Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384
Repository: mesos
Description
-------
Enabled CRAM MD5 Authentication on Windows and associated tests.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242
docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb
support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
Diff: https://reviews.apache.org/r/62106/diff/4/
Changes: https://reviews.apache.org/r/62106/diff/3-4/
Testing
-------
Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
Thanks,
John Kordich
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184911
-----------------------------------------------------------
cmake/CompilationConfigure.cmake
Lines 109-112 (original), 109-112 (patched)
<https://reviews.apache.org/r/62106/#comment261108>
It occurred to me that if we're assuming authentication support is univesally available (now true on Windows since it's bundled, and is already assumed to be true elsewhere), we should delete this entire option and make sure it's not used anywhere.
- Andrew Schwartzmeyer
On Sept. 6, 2017, 6:11 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 6:11 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
> support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
>
>
> Diff: https://reviews.apache.org/r/62106/diff/3/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184766
-----------------------------------------------------------
src/CMakeLists.txt
Line 620 (original), 616 (patched)
<https://reviews.apache.org/r/62106/#comment260970>
Hey John,
Since you're right here already. Can you to a `find_library()` guard around `sasl2` to for Linux? It's the last third party dependency (that I know of) that isn't actually a target. So this line of code ends up just being `-lsasl2` and can fail at link time instead of configuration time.
You can totally do it a separate commit, but it'll close out https://issues.apache.org/jira/browse/MESOS-3110 finally :D
Thanks!
- Andrew Schwartzmeyer
On Sept. 6, 2017, 6:11 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 6:11 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
> support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
>
>
> Diff: https://reviews.apache.org/r/62106/diff/3/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184805
-----------------------------------------------------------
FAIL: Mesos tests failed to build. Please check http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62106/logs/mesos-tests-cmake-build.log for any relevant errors
Reviews applied: [62105, 62106]
Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62106/logs
- Mesos Reviewbot Windows
On Sept. 7, 2017, 1:11 a.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 1:11 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
> support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
>
>
> Diff: https://reviews.apache.org/r/62106/diff/3/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 1:11 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
Changes
-------
Addressed comments
Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384
Repository: mesos
Description
-------
Enabled CRAM MD5 Authentication on Windows and associated tests.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
Diff: https://reviews.apache.org/r/62106/diff/3/
Changes: https://reviews.apache.org/r/62106/diff/2-3/
Testing
-------
Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
Thanks,
John Kordich
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/
-----------------------------------------------------------
(Updated Sept. 6, 2017, 8:35 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
Changes
-------
Rebased on master
Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384
Repository: mesos
Description
-------
Enabled CRAM MD5 Authentication on Windows and associated tests.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
Diff: https://reviews.apache.org/r/62106/diff/2/
Changes: https://reviews.apache.org/r/62106/diff/1-2/
Testing
-------
Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
Thanks,
John Kordich
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
and associated tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184622
-----------------------------------------------------------
FAIL: Mesos tests failed to build
Reviews applied: [62105, 62106]
Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62106/logs
- Mesos Reviewbot Windows
On Sept. 5, 2017, 7:05 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2017, 7:05 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-3384
> https://issues.apache.org/jira/browse/MESOS-3384
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled CRAM MD5 Authentication on Windows and associated tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
> docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
> src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
> src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5
> src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
> src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb
> src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
> src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
>
>
> Diff: https://reviews.apache.org/r/62106/diff/1/
>
>
> Testing
> -------
>
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
>
>
> Thanks,
>
> John Kordich
>
>