You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2023/03/21 02:48:35 UTC
[GitHub] [echarts] Ovilia commented on a diff in pull request #18376: Fix #18206 - [Feature] Enable indicators Radar charts to invert their axis
Ovilia commented on code in PR #18376:
URL: https://github.com/apache/echarts/pull/18376#discussion_r1142843294
##########
src/coord/radar/Radar.ts:
##########
@@ -67,6 +67,7 @@ class Radar implements CoordinateSystem, CoordinateSystemMaster {
indicatorAxis.name = indicatorModel.get('name');
// Inject model and axis
indicatorAxis.model = indicatorModel;
+ indicatorAxis.inverse = indicatorModel.get('inverse');
Review Comment:
This is probably not necessary to be set to `indicatorAxis.inverse`. You should call `indicatorModel.get('inverse')` whenever you need the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org