[GitHub] [superset] geido commented on a change in pull request #18144: refactor: remove redundant propTypes in ColumnElement

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #18144:
URL: https://github.com/apache/superset/pull/18144#discussion_r790954059



##########
File path: superset-frontend/src/SqlLab/components/ColumnElement/index.tsx
##########
@@ -74,14 +69,14 @@ export type ColumnKeyTypeType = keyof typeof tooltipTitleMap;
 
 interface ColumnElementProps {
   column: {
-    name: string;
+    name: React.ReactNode;

Review comment:
       Just a nit but looking at the tests and the way this is used throughout the application, I think string might still be a more appropriate type for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org