You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Dan Allen (JIRA)" <ji...@codehaus.org> on 2005/11/04 21:40:06 UTC
[jira] Created: (MNG-1430) add j2ee project nature/builders to generated .project file
add j2ee project nature/builders to generated .project file
-----------------------------------------------------------
Key: MNG-1430
URL: http://jira.codehaus.org/browse/MNG-1430
Project: Maven 2
Type: Improvement
Components: maven-eclipse-plugin
Versions: 2.0
Environment: maven 2.0 on linux
Reporter: Dan Allen
When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
<buildCommand>
<name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
<arguments>
</arguments>
</buildCommand>
<nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
<nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Commented: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by Alexandre Poitras <al...@gmail.com>.
By the wat, wtp M9 doesn't use the .deployables directory anymore.
Don't know if it has a effect on eclipse-plugin and now you can choose
easily your project structure so it's quite easy to make it fit the
maven way.
On 11/26/05, Dan Allen (JIRA) <ji...@codehaus.org> wrote:
> [ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_52070 ]
>
> Dan Allen commented on MNG-1430:
> --------------------------------
>
> Awesome! Good work. I like your idea for the wtpversion. I am assuming to override the output location, one would just use the project.build.outputDirectory and set it to .deployables
>
> > add j2ee project nature/builders to generated .project file
> > -----------------------------------------------------------
> >
> > Key: MNG-1430
> > URL: http://jira.codehaus.org/browse/MNG-1430
> > Project: Maven 2
> > Type: Improvement
> > Components: maven-eclipse-plugin
> > Versions: 2.0
> > Environment: maven 2.0 on linux
> > Reporter: Dan Allen
> > Assignee: fabrizio giustina
> > Attachments: MNG-1430.txt
> >
> >
> > When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> > <buildCommand>
> > <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> > <arguments>
> > </arguments>
> > </buildCommand>
> > <buildCommand>
> > <buildCommand>
> > <name>org.eclipse.wst.validation.validationbuilder</name>
> > <arguments>
> > </arguments>
> > </buildCommand>
> > <buildCommand>
> > <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> > </arguments>
> > </buildCommand>
> > <buildCommand>
> > <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> > <arguments>
> > </arguments>
> > </buildCommand>
> > <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> > <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://jira.codehaus.org/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Alexandre Poitras
Québec, Canada
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "Dan Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_50563 ]
Dan Allen commented on MNG-1430:
--------------------------------
Ah, ignore that last comment. WTP is not flexible enough yet to move the ".deployables" directory...it overrides any setting.
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "fabrizio giustina (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=all ]
fabrizio giustina closed MNG-1430:
----------------------------------
Assign To: fabrizio giustina
Resolution: Fixed
Committed to svn, with a few changes:
- the output dir is always set to "target". This is required for compatibility with users that don't use wtp and WTP can handle it without problems (as you already saw, you can override it as you like and WTP will always use ".deployables")
- added a new switch "wtpversion" for forward compatibility. At the moment the plugin will add configuration for wtp R7 only
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Assignee: fabrizio giustina
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "Dan Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_50562 ]
Dan Allen commented on MNG-1430:
--------------------------------
After working with my patch for a while, I think I would like to change the use of the ".deployables" directory and instead point eclipse WTP at the "target/${project.build.finalName}" directory for the output.
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "Dietrich Schulten (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_50279 ]
Dietrich Schulten commented on MNG-1430:
----------------------------------------
Not sure. Can we assume that everybody wants the wtp builders and natures for war? There are other web application plugins. Besides we would depend on the builder and nature classes used in 0.71 - what if they change for future releases as they did in the past?
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "Dan Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_52070 ]
Dan Allen commented on MNG-1430:
--------------------------------
Awesome! Good work. I like your idea for the wtpversion. I am assuming to override the output location, one would just use the project.build.outputDirectory and set it to .deployables
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Assignee: fabrizio giustina
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "Dan Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=all ]
Dan Allen updated MNG-1430:
---------------------------
Attachment: MNG-1430.txt
This patch adds the project natures and builders for the WTP 0.71 out of the box (instead of forcing every user to have to add these to the plugin configuration). After all, maven is supposed to be "smart" about your project and require little to no configuration. Maven adds these natures and builders to the .project file when the packaging is specified to be "war".
I have also configured the ".deployables" directory correctly so that eclipse will be able to import the project and deploy it without a single glitch (this includes creating this directory).
Finally, I have added a few additional dependency artifactId names that will help to determine the servlet version used in the .wtpmodules file.
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1430) add j2ee project nature/builders to generated .project file
Posted by "Dan Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_50315 ]
Dan Allen commented on MNG-1430:
--------------------------------
I don't believe that the plugin should leave out the project natures and builders simply because they *might* change. What is to say that the natures and builders for the JDT (java) eclipse plugin won't change? If they DO happen to change, then we simply update the maven eclipse plugin to include them.
About users' choice for "other web application plugins", I think it is safe to say that moving forrward, most people are moving to the WTP engine (in this case 0.71). Sure, there will be people not using it, but it will be a far smaller number and those people could potentially create their own maven plugin (or modification). Perhaps there could be an override property in the plugin configuration to NOT use WTP builders and natures (and perhaps we maintain a set).
So namely we are talking about *good* defaults. Maven is all about *good* defaults, so I say that if users complain, we simply add more overrides, but certainly don't hold back on making it work for a majority of users. Right now, exactly NO web application plugins for eclipse are supported. We generate a .wtpmodules file, but it is worthless without the proper .project configuration.
> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
> Key: MNG-1430
> URL: http://jira.codehaus.org/browse/MNG-1430
> Project: Maven 2
> Type: Improvement
> Components: maven-eclipse-plugin
> Versions: 2.0
> Environment: maven 2.0 on linux
> Reporter: Dan Allen
> Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project in maven, the .project file contains only the natures and builders for a regular java project. The additional information is as follows for WTP 0.71
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.validation.validationbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
> <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org