You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gi...@apache.org on 2017/08/11 23:27:06 UTC
[2/2] mesos git commit: Created staging dir only when needed.
Created staging dir only when needed.
Created staging dir only when needed.
Review: https://reviews.apache.org/r/61546/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d6125979
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d6125979
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d6125979
Branch: refs/heads/1.3.x
Commit: d6125979278451c1de5bc549ed24d069122ef270
Parents: f2deb04
Author: Qian Zhang <zh...@gmail.com>
Authored: Fri Aug 11 15:53:55 2017 -0700
Committer: Gilbert Song <so...@gmail.com>
Committed: Fri Aug 11 16:26:49 2017 -0700
----------------------------------------------------------------------
.../mesos/provisioner/docker/store.cpp | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/d6125979/src/slave/containerizer/mesos/provisioner/docker/store.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/provisioner/docker/store.cpp b/src/slave/containerizer/mesos/provisioner/docker/store.cpp
index 68ce265..74e17ad 100644
--- a/src/slave/containerizer/mesos/provisioner/docker/store.cpp
+++ b/src/slave/containerizer/mesos/provisioner/docker/store.cpp
@@ -249,18 +249,19 @@ Future<Image> StoreProcess::_get(
}
}
- Try<string> staging =
- os::mkdtemp(paths::getStagingTempDir(flags.docker_store_dir));
-
- if (staging.isError()) {
- return Failure("Failed to create a staging directory: " + staging.error());
- }
-
- // If there is already an pulling going on for the given 'name', we
+ // If there is already a pulling going on for the given 'name', we
// will skip the additional pulling.
const string name = stringify(reference);
if (!pulling.contains(name)) {
+ Try<string> staging =
+ os::mkdtemp(paths::getStagingTempDir(flags.docker_store_dir));
+
+ if (staging.isError()) {
+ return Failure(
+ "Failed to create a staging directory: " + staging.error());
+ }
+
Owned<Promise<Image>> promise(new Promise<Image>());
Future<Image> future = puller->pull(reference, staging.get(), backend)