You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Jeff Hagelberg <jn...@us.ibm.com> on 2016/05/02 16:09:03 UTC
Re: Review Request 46646: ATLAS-692: Add abstraction layer that
insulates Atlas from titan.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/
-----------------------------------------------------------
(Updated May 2, 2016, 2:09 p.m.)
Review request for atlas and David Kantor.
Changes
-------
Updated diff with latest version of abstraction layer.
Bugs: ATLAS-692
https://issues.apache.org/jira/browse/ATLAS-692
Repository: atlas
Description
-------
This task just creates the abstraction layer. Subsequent tasks will update Atlas to make use the interfaces in this layer rather than depending directly on Titan and bring in the titan 0.5.4/titan 1.0.0 implementations of the interfaces. See the task breakdown in [ATLAS-610](https://issues.apache.org/jira/browse/ATLAS-610) for details. If you want to see where this is headed, check out the [prototype code](https://github.com/jnhagelberg/incubator-atlas). I'm cleaning the code up there and trying to bring it into Atlas in managable chunks. This is the first piece.
Diffs (updated)
-----
.gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e
graphdb/api/pom.xml PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java PRE-CREATION
graphdb/pom.xml PRE-CREATION
pom.xml 729b1782cff96e3d0665ff570ed1999354b84c89
Diff: https://reviews.apache.org/r/46646/diff/
Testing
-------
Built entire Atlas project and ran all of the tests. No issues found. All of the tests that I expected to pass did pass.
Thanks,
Jeff Hagelberg
Re: Review Request 46646: ATLAS-692: Add abstraction layer that
insulates Atlas from titan.
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
> On May 2, 2016, 4:07 p.m., David Kantor wrote:
> > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java, line 21
> > <https://reviews.apache.org/r/46646/diff/5/?file=1368538#file1368538line21>
> >
> > Add more detail to javadoc
comment was added to demonstrate usage of RBT. Review was previously approved.
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/#review131321
-----------------------------------------------------------
On May 2, 2016, 3:58 p.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46646/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 3:58 p.m.)
>
>
> Review request for atlas and David Kantor.
>
>
> Bugs: ATLAS-692
> https://issues.apache.org/jira/browse/ATLAS-692
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This task just creates the abstraction layer. Subsequent tasks will update Atlas to make use the interfaces in this layer rather than depending directly on Titan and bring in the titan 0.5.4/titan 1.0.0 implementations of the interfaces. See the task breakdown in [ATLAS-610](https://issues.apache.org/jira/browse/ATLAS-610) for details. If you want to see where this is headed, check out the [prototype code](https://github.com/jnhagelberg/incubator-atlas). I'm cleaning the code up there and trying to bring it into Atlas in managable chunks. This is the first piece.
>
>
> Diffs
> -----
>
> .gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e
> graphdb/api/pom.xml PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java PRE-CREATION
> graphdb/pom.xml PRE-CREATION
> pom.xml 729b1782cff96e3d0665ff570ed1999354b84c89
>
> Diff: https://reviews.apache.org/r/46646/diff/
>
>
> Testing
> -------
>
> Built entire Atlas project and ran all of the tests. No issues found. All of the tests that I expected to pass did pass.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 46646: ATLAS-692: Add abstraction layer that
insulates Atlas from titan.
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/#review131321
-----------------------------------------------------------
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java (line 21)
<https://reviews.apache.org/r/46646/#comment195256>
Add more detail to javadoc
- David Kantor
On May 2, 2016, 3:58 p.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46646/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 3:58 p.m.)
>
>
> Review request for atlas and David Kantor.
>
>
> Bugs: ATLAS-692
> https://issues.apache.org/jira/browse/ATLAS-692
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This task just creates the abstraction layer. Subsequent tasks will update Atlas to make use the interfaces in this layer rather than depending directly on Titan and bring in the titan 0.5.4/titan 1.0.0 implementations of the interfaces. See the task breakdown in [ATLAS-610](https://issues.apache.org/jira/browse/ATLAS-610) for details. If you want to see where this is headed, check out the [prototype code](https://github.com/jnhagelberg/incubator-atlas). I'm cleaning the code up there and trying to bring it into Atlas in managable chunks. This is the first piece.
>
>
> Diffs
> -----
>
> .gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e
> graphdb/api/pom.xml PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java PRE-CREATION
> graphdb/pom.xml PRE-CREATION
> pom.xml 729b1782cff96e3d0665ff570ed1999354b84c89
>
> Diff: https://reviews.apache.org/r/46646/diff/
>
>
> Testing
> -------
>
> Built entire Atlas project and ran all of the tests. No issues found. All of the tests that I expected to pass did pass.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 46646: ATLAS-692: Add abstraction layer that
insulates Atlas from titan.
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/
-----------------------------------------------------------
(Updated May 2, 2016, 3:58 p.m.)
Review request for atlas and David Kantor.
Bugs: ATLAS-692
https://issues.apache.org/jira/browse/ATLAS-692
Repository: atlas
Description
-------
This task just creates the abstraction layer. Subsequent tasks will update Atlas to make use the interfaces in this layer rather than depending directly on Titan and bring in the titan 0.5.4/titan 1.0.0 implementations of the interfaces. See the task breakdown in [ATLAS-610](https://issues.apache.org/jira/browse/ATLAS-610) for details. If you want to see where this is headed, check out the [prototype code](https://github.com/jnhagelberg/incubator-atlas). I'm cleaning the code up there and trying to bring it into Atlas in managable chunks. This is the first piece.
Diffs (updated)
-----
.gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e
graphdb/api/pom.xml PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java PRE-CREATION
graphdb/pom.xml PRE-CREATION
pom.xml 729b1782cff96e3d0665ff570ed1999354b84c89
Diff: https://reviews.apache.org/r/46646/diff/
Testing
-------
Built entire Atlas project and ran all of the tests. No issues found. All of the tests that I expected to pass did pass.
Thanks,
Jeff Hagelberg
Re: Review Request 46646: ATLAS-692: Add abstraction layer that
insulates Atlas from titan.
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/#review131314
-----------------------------------------------------------
Ship it!
Ship It!
- David Kantor
On May 2, 2016, 2:13 p.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46646/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 2:13 p.m.)
>
>
> Review request for atlas and David Kantor.
>
>
> Bugs: ATLAS-692
> https://issues.apache.org/jira/browse/ATLAS-692
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This task just creates the abstraction layer. Subsequent tasks will update Atlas to make use the interfaces in this layer rather than depending directly on Titan and bring in the titan 0.5.4/titan 1.0.0 implementations of the interfaces. See the task breakdown in [ATLAS-610](https://issues.apache.org/jira/browse/ATLAS-610) for details. If you want to see where this is headed, check out the [prototype code](https://github.com/jnhagelberg/incubator-atlas). I'm cleaning the code up there and trying to bring it into Atlas in managable chunks. This is the first piece.
>
>
> Diffs
> -----
>
> .gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e
> graphdb/api/pom.xml PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java PRE-CREATION
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java PRE-CREATION
> graphdb/pom.xml PRE-CREATION
> pom.xml 729b1782cff96e3d0665ff570ed1999354b84c89
>
> Diff: https://reviews.apache.org/r/46646/diff/
>
>
> Testing
> -------
>
> Built entire Atlas project and ran all of the tests. No issues found. All of the tests that I expected to pass did pass.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 46646: ATLAS-692: Add abstraction layer that
insulates Atlas from titan.
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/
-----------------------------------------------------------
(Updated May 2, 2016, 2:13 p.m.)
Review request for atlas and David Kantor.
Bugs: ATLAS-692
https://issues.apache.org/jira/browse/ATLAS-692
Repository: atlas
Description
-------
This task just creates the abstraction layer. Subsequent tasks will update Atlas to make use the interfaces in this layer rather than depending directly on Titan and bring in the titan 0.5.4/titan 1.0.0 implementations of the interfaces. See the task breakdown in [ATLAS-610](https://issues.apache.org/jira/browse/ATLAS-610) for details. If you want to see where this is headed, check out the [prototype code](https://github.com/jnhagelberg/incubator-atlas). I'm cleaning the code up there and trying to bring it into Atlas in managable chunks. This is the first piece.
Diffs (updated)
-----
.gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e
graphdb/api/pom.xml PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java PRE-CREATION
graphdb/pom.xml PRE-CREATION
pom.xml 729b1782cff96e3d0665ff570ed1999354b84c89
Diff: https://reviews.apache.org/r/46646/diff/
Testing
-------
Built entire Atlas project and ran all of the tests. No issues found. All of the tests that I expected to pass did pass.
Thanks,
Jeff Hagelberg