You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/15 02:56:56 UTC
svn commit: r1748482 -
/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
Author: onealj
Date: Wed Jun 15 02:56:56 2016
New Revision: 1748482
URL: http://svn.apache.org/viewvc?rev=1748482&view=rev
Log:
bug 57840: make it easier to replace _rows implementation (HashMap?) by making it final
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java?rev=1748482&r1=1748481&r2=1748482&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java Wed Jun 15 02:56:56 2016
@@ -110,7 +110,7 @@ public class XSSFSheet extends POIXMLDoc
protected CTSheet sheet;
protected CTWorksheet worksheet;
- private SortedMap<Integer, XSSFRow> _rows;
+ private final SortedMap<Integer, XSSFRow> _rows = new TreeMap<Integer, XSSFRow>();
private List<XSSFHyperlink> hyperlinks;
private ColumnHelper columnHelper;
private CommentsTable sheetComments;
@@ -216,7 +216,7 @@ public class XSSFSheet extends POIXMLDoc
}
private void initRows(CTWorksheet worksheetParam) {
- _rows = new TreeMap<Integer, XSSFRow>();
+ _rows.clear();
tables = new TreeMap<String, XSSFTable>();
sharedFormulas = new HashMap<Integer, CTCellFormula>();
arrayFormulas = new ArrayList<CellRangeAddress>();
@@ -3024,13 +3024,14 @@ public class XSSFSheet extends POIXMLDoc
rowShifter.updateHyperlinks(shifter);
//rebuild the _rows map
- SortedMap<Integer, XSSFRow> map = new TreeMap<Integer, XSSFRow>();
+ Map<Integer, XSSFRow> map = new HashMap<Integer, XSSFRow>();
for(XSSFRow r : _rows.values()) {
// Performance optimization: explicit boxing is slightly faster than auto-unboxing, though may use more memory
final Integer rownumI = new Integer(r.getRowNum()); // NOSONAR
map.put(rownumI, r);
}
- _rows = map;
+ _rows.clear();
+ _rows.putAll(map);
}
private int shiftedRowNum(int startRow, int endRow, int n, int rownum) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org