You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/12 05:39:56 UTC

[GitHub] [incubator-kyuubi] 942011334 opened a new pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

942011334 opened a new pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110


   …initialization times out and yarn application status is accepted
   
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] 942011334 commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
942011334 commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065906671


   hello , when&nbsp;use scalatestplus-mockito instead ,"build/dependency.sh" test failed, help me to see the problem , tanks!
   
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: "Kent ***@***.***&gt;; 
   发送时间: 2022年3月12日(星期六) 晚上9:14
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/incubator-kyuubi] [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine … (PR #2110)
   
   
   
   
   
    
   @pan3793 commented on this pull request.
    
    
   In kyuubi-server/pom.xml:
    &gt; @@ -385,6 +385,13 @@              <scope&gt;test</scope&gt;          </dependency&gt;   +        <dependency&gt; +            <groupId&gt;org.mockito</groupId&gt; +            <artifactId&gt;mockito-core</artifactId&gt; +            <scope&gt;test</scope&gt; +            <version&gt;3.4.6</version&gt;  
   Please use scalatestplus-mockito instead.
    <properties&gt;     <scalatestplus.version&gt;3.2.9.0</scalatestplus.version&gt; </properties&gt; <dependency&gt;     <groupId&gt;org.scalatestplus</groupId&gt;     <artifactId&gt;mockito-3-4_${scala.binary.version}</artifactId&gt;     <version&gt;${scalatestplus.version}</version&gt; </dependency&gt;  
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you were mentioned.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065890355


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2110](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2db9c45) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7d66e9aa50ed012c545df8f99c8991705e6635b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d66e9a) will **increase** coverage by `0.48%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2110      +/-   ##
   ============================================
   + Coverage     60.70%   61.19%   +0.48%     
     Complexity      108      108              
   ============================================
     Files           320      317       -3     
     Lines         15468    15440      -28     
     Branches       1989     1986       -3     
   ============================================
   + Hits           9390     9448      +58     
   + Misses         5273     5188      -85     
   + Partials        805      804       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `88.46% <100.00%> (+1.79%)` | :arrow_up: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.12% <0.00%> (-0.83%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `91.66% <0.00%> (ø)` | |
   | [...he/hadoop/hive/thrift/TUGIContainingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RVR0lDb250YWluaW5nVHJhbnNwb3J0LmphdmE=) | | |
   | [...rg/apache/hadoop/hive/thrift/TFilterTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RGaWx0ZXJUcmFuc3BvcnQuamF2YQ==) | | |
   | [...doop/hive/thrift/client/TUGIAssumingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L2NsaWVudC9UVUdJQXNzdW1pbmdUcmFuc3BvcnQuamF2YQ==) | | |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.54% <0.00%> (+0.09%)` | :arrow_up: |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `92.77% <0.00%> (+0.66%)` | :arrow_up: |
   | [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `89.36% <0.00%> (+1.26%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d66e9a...2db9c45](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825322426



##########
File path: pom.xml
##########
@@ -888,6 +888,13 @@
                 <scope>test</scope>
             </dependency>
 
+            <dependency>
+                <groupId>org.scalatestplus</groupId>
+                <artifactId>mockito-3-4_${scala.binary.version}</artifactId>
+                <version>${scalatestplus.version}</version>
+                <scope>test</scope>

Review comment:
       we don't need `<scope>test</scope>` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825392629



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -44,6 +45,10 @@ class SparkProcessBuilder(
 
   import SparkProcessBuilder._
 
+  val yarnClient = getYarnClient
+
+  def getYarnClient: YarnClient = YarnClient.createYarnClient

Review comment:
       @wForget, what about `createYarnClient`? @942011334, sorry to suggest a bit confusing method name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825322385



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala
##########
@@ -242,7 +244,7 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper {
   test("kill application") {
     val pb1 = new FakeSparkProcessBuilder(conf) {
       override protected def env: Map[String, String] = Map()
-      override def getYarnClient: YarnClient = mock(classOf[YarnClient])
+      override def getYarnClient: YarnClient = mock(classTag[YarnClient])

Review comment:
       `mock(classTag[YarnClient])` can be simplified to `mock[YarnClient]`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065848294


   Please help to update the title to `[Kyuubi #2104] Kill yarn job using yarn client API when kyuubi engine …`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] 942011334 commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
942011334 commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1066031635


   yes, the purpose is to override this method for the test class .
   
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: "Kent ***@***.***&gt;; 
   发送时间: 2022年3月13日(星期天) 中午1:20
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/incubator-kyuubi] [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine … (PR #2110)
   
   
   
   
   
    
   @wForget commented on this pull request.
    
    
   In kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
    &gt; @@ -44,6 +45,10 @@ class SparkProcessBuilder(      import SparkProcessBuilder._   +  val yarnClient = getYarnClient + +  def getYarnClient: YarnClient = YarnClient.createYarnClient  
   The name of getYarnClient method seems to be a little confused. It looks like the getter method of yarnClient variable.
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you were assigned.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825273376



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -44,6 +45,8 @@ class SparkProcessBuilder(
 
   import SparkProcessBuilder._
 
+  var yarnClient = YarnClient.createYarnClient

Review comment:
       ```suggestion
     val yarnClient = getYarnClient
     
     def getYarnClient: YarnClient = YarnClient.createYarnClient
   ```
   In the test, you could override the `getYarnClient` method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065890355


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2110](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38118aa) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7d66e9aa50ed012c545df8f99c8991705e6635b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d66e9a) will **increase** coverage by `0.45%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2110      +/-   ##
   ============================================
   + Coverage     60.70%   61.16%   +0.45%     
     Complexity      108      108              
   ============================================
     Files           320      317       -3     
     Lines         15468    15440      -28     
     Branches       1989     1986       -3     
   ============================================
   + Hits           9390     9444      +54     
   + Misses         5273     5189      -84     
   - Partials        805      807       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `88.46% <100.00%> (+1.79%)` | :arrow_up: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.12% <0.00%> (-0.83%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.40% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `91.66% <0.00%> (ø)` | |
   | [...he/hadoop/hive/thrift/TUGIContainingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RVR0lDb250YWluaW5nVHJhbnNwb3J0LmphdmE=) | | |
   | [...rg/apache/hadoop/hive/thrift/TFilterTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RGaWx0ZXJUcmFuc3BvcnQuamF2YQ==) | | |
   | [...doop/hive/thrift/client/TUGIAssumingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L2NsaWVudC9UVUdJQXNzdW1pbmdUcmFuc3BvcnQuamF2YQ==) | | |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `92.77% <0.00%> (+0.66%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d66e9a...38118aa](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825300546



##########
File path: kyuubi-server/pom.xml
##########
@@ -385,6 +385,13 @@
             <scope>test</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+            <scope>test</scope>
+            <version>3.4.6</version>

Review comment:
       Please use scalatestplus-mockito instead.
   ```
   <properties>
       <scalatestplus.version>3.2.9.0</scalatestplus.version>
   </properties>
   
   <dependency>
       <groupId>org.scalatestplus</groupId>
       <artifactId>mockito-3-4_${scala.binary.version}</artifactId>
       <version>${scalatestplus.version}</version>
   </dependency>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065891092


   cc @cxzl25 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] 942011334 commented on pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
942011334 commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065843179


   good idea .
   
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: "Kent ***@***.***&gt;; 
   发送时间: 2022年3月12日(星期六) 下午4:34
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/incubator-kyuubi] [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine … (PR #2110)
   
   
   
   
   
    
   @yaooqinn commented on this pull request.
    
    
   In kyuubi-server/pom.xml:
    &gt; @@ -385,6 +385,13 @@              <scope&gt;test</scope&gt;          </dependency&gt;   +        <dependency&gt; +            <groupId&gt;org.mockito</groupId&gt; +            <artifactId&gt;mockito-core</artifactId&gt; +            <scope&gt;test</scope&gt; +            <version&gt;3.4.6</version&gt;  
   can we add it to dependencyManagement then inherit it here？
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you authored the thread.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065890355


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2110](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38118aa) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7d66e9aa50ed012c545df8f99c8991705e6635b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d66e9a) will **increase** coverage by `0.45%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 38118aa differs from pull request most recent head 6bb4f37. Consider uploading reports for the commit 6bb4f37 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2110      +/-   ##
   ============================================
   + Coverage     60.70%   61.16%   +0.45%     
     Complexity      108      108              
   ============================================
     Files           320      317       -3     
     Lines         15468    15440      -28     
     Branches       1989     1986       -3     
   ============================================
   + Hits           9390     9444      +54     
   + Misses         5273     5189      -84     
   - Partials        805      807       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `88.46% <100.00%> (+1.79%)` | :arrow_up: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.12% <0.00%> (-0.83%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.40% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `91.66% <0.00%> (ø)` | |
   | [...rg/apache/hadoop/hive/thrift/TFilterTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RGaWx0ZXJUcmFuc3BvcnQuamF2YQ==) | | |
   | [...he/hadoop/hive/thrift/TUGIContainingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RVR0lDb250YWluaW5nVHJhbnNwb3J0LmphdmE=) | | |
   | [...doop/hive/thrift/client/TUGIAssumingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L2NsaWVudC9UVUdJQXNzdW1pbmdUcmFuc3BvcnQuamF2YQ==) | | |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `92.77% <0.00%> (+0.66%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d66e9a...6bb4f37](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065907133


   > hello , when&nbsp;use scalatestplus-mockito instead ,"build/dependency.sh" test failed, help me to see the problem , tanks!
   > […](#)
   > ------------------&nbsp;原始邮件&nbsp;------------------ 发件人: "Kent ***@***.***&gt;; 发送时间: 2022年3月12日(星期六) 晚上9:14 收件人: ***@***.***&gt;; 抄送: ***@***.***&gt;; ***@***.***&gt;; 主题: Re: [apache/incubator-kyuubi] [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine … (PR #2110) @pan3793 commented on this pull request. In kyuubi-server/pom.xml: &gt; @@ -385,6 +385,13 @@ <scope&gt;test</scope&gt; </dependency&gt; + <dependency&gt; + <groupId&gt;org.mockito</groupId&gt; + <artifactId&gt;mockito-core</artifactId&gt; + <scope&gt;test</scope&gt; + <version&gt;3.4.6</version&gt; Please use scalatestplus-mockito instead. <properties&gt; <scalatestplus.version&gt;3.2.9.0</scalatestplus.version&gt; </properties&gt; <dependency&gt; <groupId&gt;org.scalatestplus</groupId&gt; <artifactId&gt;mockito-3-4_${scala.binary.version}</artifactId&gt; <version&gt;${scalatestplus.version}</version&gt; </dependency&gt; — Reply to this email
  directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: ***@***.***&gt;
   
   You pinned `<artifactId>mockito-3-4_${scala.binary.version}</artifactId>` in `compile` scope, please take a look at my comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065890355


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2110](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2db9c45) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7d66e9aa50ed012c545df8f99c8991705e6635b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d66e9a) will **increase** coverage by `0.48%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 2db9c45 differs from pull request most recent head 38118aa. Consider uploading reports for the commit 38118aa to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2110      +/-   ##
   ============================================
   + Coverage     60.70%   61.19%   +0.48%     
     Complexity      108      108              
   ============================================
     Files           320      317       -3     
     Lines         15468    15440      -28     
     Branches       1989     1986       -3     
   ============================================
   + Hits           9390     9448      +58     
   + Misses         5273     5188      -85     
   + Partials        805      804       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `88.46% <100.00%> (+1.79%)` | :arrow_up: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.12% <0.00%> (-0.83%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `91.66% <0.00%> (ø)` | |
   | [...doop/hive/thrift/client/TUGIAssumingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L2NsaWVudC9UVUdJQXNzdW1pbmdUcmFuc3BvcnQuamF2YQ==) | | |
   | [...rg/apache/hadoop/hive/thrift/TFilterTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RGaWx0ZXJUcmFuc3BvcnQuamF2YQ==) | | |
   | [...he/hadoop/hive/thrift/TUGIContainingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RVR0lDb250YWluaW5nVHJhbnNwb3J0LmphdmE=) | | |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.54% <0.00%> (+0.09%)` | :arrow_up: |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `92.77% <0.00%> (+0.66%)` | :arrow_up: |
   | [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `89.36% <0.00%> (+1.26%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d66e9a...38118aa](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] 942011334 commented on a change in pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
942011334 commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825272816



##########
File path: kyuubi-server/pom.xml
##########
@@ -385,6 +385,13 @@
             <scope>test</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+            <scope>test</scope>
+            <version>3.4.6</version>

Review comment:
       ok, good idea.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825273495



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -195,20 +198,20 @@ class SparkProcessBuilder(
   override def killApplication(line: String = lastRowsOfLog.toArray.mkString("\n")): String =
     YARN_APP_NAME_REGEX.findFirstIn(line) match {
       case Some(appId) =>
-        env.get(KyuubiConf.KYUUBI_HOME) match {
-          case Some(kyuubiHome) =>
-            val pb = new ProcessBuilder("/bin/sh", s"$kyuubiHome/bin/stop-application.sh", appId)
-            pb.environment()
-              .putAll(childProcEnv.asJava)
-            pb.redirectError(Redirect.appendTo(engineLog))
-            pb.redirectOutput(Redirect.appendTo(engineLog))
-            val process = pb.start()
-            process.waitFor() match {
-              case id if id != 0 => s"Failed to kill Application $appId, please kill it manually. "
-              case _ => s"Killed Application $appId successfully. "
-            }
-          case None =>
-            s"KYUUBI_HOME is not set! Failed to kill Application $appId, please kill it manually."
+        try {
+          val hadoopConf = KyuubiHadoopUtils.newHadoopConf(conf)
+          yarnClient.init(hadoopConf)
+          yarnClient.start()
+          val applicationId = ApplicationId.fromString(appId)
+          yarnClient.killApplication(applicationId)
+          s"Killed Application $appId successfully."
+        } catch {
+          case e: Throwable =>
+            s"Failed to kill Application $appId, Caused by ${e.getMessage}."

Review comment:
       Adds the `Please kill it manually.` in the message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065841623


   thanks @942011334  for the contibution, also cc @wForget @SteNicholas @pan3793 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1066272396


   thanks @942011334 for the first contribution, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
wForget commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825393548



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -44,6 +45,10 @@ class SparkProcessBuilder(
 
   import SparkProcessBuilder._
 
+  val yarnClient = getYarnClient
+
+  def getYarnClient: YarnClient = YarnClient.createYarnClient

Review comment:
       > what about createYarnClient?
   
   LGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2110: [Kyuubi#2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825269175



##########
File path: kyuubi-server/pom.xml
##########
@@ -385,6 +385,13 @@
             <scope>test</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+            <scope>test</scope>
+            <version>3.4.6</version>

Review comment:
       can we add it to dependencyManagement then inherit it here？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065890355


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2110](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28665f3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7d66e9aa50ed012c545df8f99c8991705e6635b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d66e9a) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 28665f3 differs from pull request most recent head 2db9c45. Consider uploading reports for the commit 2db9c45 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2110      +/-   ##
   ============================================
   - Coverage     60.70%   60.68%   -0.03%     
     Complexity      108      108              
   ============================================
     Files           320      320              
     Lines         15468    15465       -3     
     Branches       1989     1987       -2     
   ============================================
   - Hits           9390     9385       -5     
   - Misses         5273     5276       +3     
   + Partials        805      804       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `88.23% <100.00%> (+1.56%)` | :arrow_up: |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `61.33% <0.00%> (-1.34%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d66e9a...2db9c45](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
wForget commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825389816



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -44,6 +45,10 @@ class SparkProcessBuilder(
 
   import SparkProcessBuilder._
 
+  val yarnClient = getYarnClient
+
+  def getYarnClient: YarnClient = YarnClient.createYarnClient

Review comment:
       The name of `getYarnClient` method seems to be a little confused. It looks like the `getter` method of `yarnClient` variable.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#discussion_r825306444



##########
File path: pom.xml
##########
@@ -127,6 +127,7 @@
         <kubernetes-client.version>5.12.1</kubernetes-client.version>
         <ldapsdk.version>5.1.4</ldapsdk.version>
         <mysql.jdbc.version>8.0.27</mysql.jdbc.version>
+        <scalatestplus.version>3.2.9.0</scalatestplus.version>

Review comment:
       Move this line after `<scalatest.version>`

##########
File path: kyuubi-server/pom.xml
##########
@@ -386,10 +386,8 @@
         </dependency>
 
         <dependency>
-            <groupId>org.mockito</groupId>
-            <artifactId>mockito-core</artifactId>
-            <scope>test</scope>
-            <version>3.4.6</version>
+            <groupId>org.scalatestplus</groupId>
+            <artifactId>mockito-3-4_${scala.binary.version}</artifactId>

Review comment:
       `<scope>test</scope>`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065907133


   > hello , when&nbsp;use scalatestplus-mockito instead ,"build/dependency.sh" test failed, help me to see the problem , tanks!
   
   You pinned `<artifactId>mockito-3-4_${scala.binary.version}</artifactId>` in `compile` scope, please take a look at my comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1065890355


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2110](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bb4f37) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7d66e9aa50ed012c545df8f99c8991705e6635b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d66e9a) will **increase** coverage by `0.48%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2110      +/-   ##
   ============================================
   + Coverage     60.70%   61.19%   +0.48%     
     Complexity      108      108              
   ============================================
     Files           320      317       -3     
     Lines         15468    15440      -28     
     Branches       1989     1986       -3     
   ============================================
   + Hits           9390     9448      +58     
   + Misses         5273     5186      -87     
   - Partials        805      806       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `88.46% <100.00%> (+1.79%)` | :arrow_up: |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.12% <0.00%> (-0.83%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.40% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `91.66% <0.00%> (ø)` | |
   | [...he/hadoop/hive/thrift/TUGIContainingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RVR0lDb250YWluaW5nVHJhbnNwb3J0LmphdmE=) | | |
   | [...doop/hive/thrift/client/TUGIAssumingTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L2NsaWVudC9UVUdJQXNzdW1pbmdUcmFuc3BvcnQuamF2YQ==) | | |
   | [...rg/apache/hadoop/hive/thrift/TFilterTransport.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvdGhyaWZ0L1RGaWx0ZXJUcmFuc3BvcnQuamF2YQ==) | | |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `92.77% <0.00%> (+0.66%)` | :arrow_up: |
   | [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `89.36% <0.00%> (+1.26%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d66e9a...6bb4f37](https://codecov.io/gh/apache/incubator-kyuubi/pull/2110?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] 942011334 commented on pull request #2110: [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine …

Posted by GitBox <gi...@apache.org>.
942011334 commented on pull request #2110:
URL: https://github.com/apache/incubator-kyuubi/pull/2110#issuecomment-1066036547


   Thanks to every expert's guidance, support and help.
   
   
   
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: "Kent ***@***.***&gt;; 
   发送时间: 2022年3月13日(星期天) 下午2:12
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/incubator-kyuubi] [KYUUBI #2104] Kill yarn job using yarn client API when kyuubi engine … (PR #2110)
   
   
   
   
   
    
   @wForget commented on this pull request.
    
    
   In kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
    &gt; @@ -44,6 +45,10 @@ class SparkProcessBuilder(      import SparkProcessBuilder._   +  val yarnClient = getYarnClient + +  def getYarnClient: YarnClient = YarnClient.createYarnClient   
   what about createYarnClient?
     
   LGTM
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you were mentioned.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org