You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/12/24 08:37:53 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/569
[ZEPPELIN-391] Keyboard shortcut
### What is this PR for?
This PR implements keyboard shortcuts for paragraph control.
### What type of PR is it?
Feature
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-391
### How should this be tested?
Try implemented shortcuts
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/incubator-zeppelin keyboard_shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #569
----
commit 42654c47d6cbc2f9d82f2409bb3b7f23fc658d83
Author: Lee moon soo <mo...@apache.org>
Date: 2015-12-24T07:05:28Z
Focus paragraph on click
commit bf8a0b078b58988feb4b2a2805ef987b3c231113
Author: Lee moon soo <mo...@apache.org>
Date: 2015-12-24T07:35:21Z
Add keyboard shortcuts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167372344
I'll create an issue for shortcut on IE.
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167130741
Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167370653
@Leemoonsoo sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167180651
Ctrl + c is commonly used to copy highlighted text to the clipboard so better to change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167180989
Ctrl + Alt + k and Ctrl + Alt + E does work on chrome, firefox but not on IE
and Ctrl + Alt + 1~0,-,+ doesn't work on all three browsers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-391] Keyboard shortcut
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/569#issuecomment-167180845
@minahlee You're right. Changed to Ctrl+Alt+c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---