You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by FSchumacher <gi...@git.apache.org> on 2019/02/03 11:42:17 UTC
[GitHub] jmeter pull request #438: Try running on java-ea for travis builds.
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/438
Try running on java-ea for travis builds.
## Description
Enable builds for Java EA on travis ci
## Motivation and Context
We should get early warnings, when JMeter doesn't run on EA versions of Java.
## How Has This Been Tested?
Will get tested by travis :)
## Screenshots (if appropriate):
## Types of changes
- New feature (non-breaking change which adds functionality)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FSchumacher/jmeter java-ea-for-travis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
----
commit 81f80e459e84eaa338b1bdc5906837aaea9e953c
Author: Felix Schumacher <fe...@...>
Date: 2019-02-03T11:39:27Z
Try running on java-ea for travis builds.
----
---
[GitHub] jmeter issue #438: Try running on java-ea for travis builds.
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/438
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=h1) Report
> Merging [#438](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/b5ec77f3fae4fb7322ad3cb7820c4f07f9b16271?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #438 +/- ##
============================================
- Coverage 58.57% 58.56% -0.01%
+ Complexity 10776 10775 -1
============================================
Files 1206 1206
Lines 77193 77193
Branches 7456 7456
============================================
- Hits 45213 45211 -2
- Misses 29452 29453 +1
- Partials 2528 2529 +1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/438/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh) | `72.97% <0%> (-5.41%)` | `9% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=footer). Last update [b5ec77f...02829d2](https://codecov.io/gh/apache/jmeter/pull/438?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter issue #438: Try running on java-ea for travis builds.
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/438
Hi Felix,
Since you're working on this.
I see that when when we use openjdk11, we have those warnings:
warning: [options] bootstrap class path not set in conjunction with -source 8
Shouldn't we set source and target to 11 ?
Regards
---
[GitHub] jmeter pull request #438: Try running on java-ea for travis builds.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/438
---
[GitHub] jmeter issue #438: Try running on java-ea for travis builds.
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/438
> Hi Felix,
> Since you're working on this.
> I see that when when we use openjdk11, we have those warnings:
>
> warning: [options] bootstrap class path not set in conjunction with -source 8
>
> Shouldn't we set source and target to 11 ?
> Regards
Well, as long as we are on Java 8 as minimum version, we should compile with something, that is *compatible*. That probably means:
* set the bootstrap class to a JDK from version 8 as shown on https://ant.apache.org/manual/Tasks/javac.html#bootstrap
* use a JDK 8 to compile and run the the tests with newer versions
But for this PR I am happy to have included the EA builds (even if they are failing right now)
---
[GitHub] jmeter issue #438: Try running on java-ea for travis builds.
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/438
+1
---