You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/06/01 06:11:03 UTC
[GitHub] [incubator-seatunnel] leo65535 opened a new pull request, #1980: [Bug][build] Fix build failed
leo65535 opened a new pull request, #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Met exception when build sub module.
```
cd seatunnel-apis/seatunnel-api-base
mvn clean package -DskipTests
```
```
[ERROR] Failed to execute goal on project seatunnel-api-base: Could not resolve dependencies for project org.apache.seatunnel:seatunnel-api-base:jar:2.1.1-SNAPSHOT: Failed to collect dependencies at org.apache.seatunnel:seatunnel-common:jar:2.1.1-SNAPSHOT: Failed to read artifact descriptor for org.apache.seatunnel:seatunnel-common:jar:2.1.1-SNAPSHOT: Could not find artifact org.apache.seatunnel:seatunnel:pom:${revision} in aliyun (https://maven.aliyun.com/repository/public/) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[dcadmin@dcadmin-work seatunnel-api-base]$ pwd
/work/projects/opensource/seatunnel/incubator-seatunnel/seatunnel-apis/seatunnel-api-base
```
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143315412
> > In my view, perhaps we need new packge method to avoid this problem, but the way you submit in this PR can't pass.
>
> it will make things more complex, and all other apache projects also do this, like spark、flink、hadoop
SeaTunnel also do this way before 😂 #1672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143238754
> > > Maybe we can create a assembly without connector, or just including fake and console?
> >
> >
> > In fact, we can not build any sub modules, like seatunnel-core-base, seatunnel-e2e, etc
>
> I mean, we can build root project without connector, so that the build will be faster, save developer's time. I think you want only build sub project because build root project waste time, am I right?
When we need connectors, we will also met same failure 😭
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143232749
> > Maybe we can create a assembly without connector, or just including fake and console?
>
> In fact, we can not build any sub modules, like seatunnel-core-base, seatunnel-e2e, etc
I mean, we can build root project without connector, so that the build will be faster, save developer's time. I think you want only build sub project because build root project waste time, am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143158487
@ruanwenjun @CalvinKirs take a review when free, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 merged pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 merged PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1144684295
hi @ruanwenjun, the plugin worked in local env, but it will generate files, I had add it to .gitignore file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143222444
> hi @BenJFan
>
> > Seem like SeaTunnel only can build on root directory,
>
> This is unfriendly for develoers, because we have many connectors.
>
> > you can just add a properties in seatunnel-api-base/pom.xml named revision, and set value to 2.1.1-SNAPSHOT. After you execute mvn install, I think the build will passed.
>
> It seems not a good practice, we need to add revision propertites to all sub modules
>
> > After you change this, if we use version which not release on maven repository, you also will build failed, because you dependency get from maven repository not local
>
> Right, we should build root project, then we can build sub module. But it failed when build sub module in dev branch.
Maybe we can create a assembly without connector, or just including fake and console?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143322935
> > > In my view, perhaps we need new packge method to avoid this problem, but the way you submit in this PR can't pass.
> >
> >
> > it will make things more complex, and all other apache projects also do this, like spark、flink、hadoop
>
> SeaTunnel also do this way before 😂 #1672
You're right. We need to revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143203694
you can just add a properties in seatunnel-api-base/pom.xml named `revision`, and set value to `2.1.1-SNAPSHOT`. After you execute `mvn install`, I think the build will passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143372961
Good catch, we may need to find a better way to manage the version. The reason to use `${revision}` is hope that we can manage the project version in one way, when we want to change the project version, we can only change the parent pom or set by `-Drevision`.
This indeed unfriendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143217204
hi @BenJFan
> Seem like SeaTunnel only can build on root directory,
This is unfriendly for develoers.
> you can just add a properties in seatunnel-api-base/pom.xml named revision, and set value to 2.1.1-SNAPSHOT. After you execute mvn install, I think the build will passed.
It seems not a good practice, we need to add revision propertites to all sub modules
> After you change this, if we use version which not release on maven repository, you also will build failed, because you dependency get from maven repository not local
Right, we should build root project, then we can build sub module. But it failed when build sub module in dev branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143201194
Seem like SeaTunnel only can build on root directory, after you change this, if we use version which not release on maven repository, you also will build failed, because you dependency get from maven repository not local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143281527
> In my view, perhaps we need new packge method to avoid this problem, but the way you submit in this PR can't pass.
it will make things more complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1146941416
Thanks @BenJFan @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1144875950
@CalvinKirs @BenJFan Please take a look, this will affect the build process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143226292
> Maybe we can create a assembly without connector, or just including fake and console?
In fact, we can not build any sub modules, like seatunnel-core-base, seatunnel-e2e, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1143269014
> > > > Maybe we can create a assembly without connector, or just including fake and console?
> > >
> > >
> > > In fact, we can not build any sub modules, like seatunnel-core-base, seatunnel-e2e, etc
> >
> >
> > I mean, we can build root project without connector, so that the build will be faster, save developer's time. I think you want only build sub project because build root project waste time, am I right?
>
> When we need connectors, we will also met same failure 😭
> > > > Maybe we can create a assembly without connector, or just including fake and console?
> > >
> > >
> > > In fact, we can not build any sub modules, like seatunnel-core-base, seatunnel-e2e, etc
> >
> >
> > I mean, we can build root project without connector, so that the build will be faster, save developer's time. I think you want only build sub project because build root project waste time, am I right?
>
> When we need connectors, we will also met same failure 😭
In my view, perhaps we need new packge method to avoid this problem, but the way you submit in this PR can't pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1980: [Bug][build] Fix build failed
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1980:
URL: https://github.com/apache/incubator-seatunnel/pull/1980#issuecomment-1144494902
Tried `flatten-maven-plugin`, it will generate `.flattened-pom.xml` files.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org