You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2008/09/26 03:27:44 UTC

[jira] Created: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

User configurable filter fails to filter accesses to certain directories
------------------------------------------------------------------------

                 Key: HADOOP-4282
                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
             Project: Hadoop Core
          Issue Type: Bug
          Components: dfs
    Affects Versions: 0.18.1
            Reporter: Kan Zhang


Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645014#action_12645014 ] 

Kan Zhang commented on HADOOP-4282:
-----------------------------------

Your patch effectively changes the semantics of addFilter to that of addGlobalFilter in the current 0.20 trunk. I thought the reason to have addFilter method in the first place is to make filters added through this method filter some but not all requests (on the other hand, filters added through addGlobalFilter will filter all requests). How do you go about fixing the same bug in the 0.20 trunk? Make addFilter and addGlobalFilter equivalent?

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646411#action_12646411 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4282:
------------------------------------------------

The javadoc warning was due to HADOOP-4621.  I am not resubmitting the new patch since there is only a log message change.

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch, 4282_20081110.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646404#action_12646404 ] 

Chris Douglas commented on HADOOP-4282:
---------------------------------------

{noformat}
-        handler.addFilterPathMapping(ctx.getContextPath() + "/*", name,
-            Dispatcher.__ALL);
+        defineFilter(ctx, name, classname, parameters, ALL_URLS);
         LOG.info("Added filter " + name + " (class=" + classname
             + ") to context path " + ctx.getContextPath() + "/*");
{noformat}

The log message should probably use Arrays.toString(ALL_URLS) instead of "/*"; otherwise +1

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642319#action_12642319 ] 

Kan Zhang commented on HADOOP-4282:
-----------------------------------

Note that with HADOOP-4284 now committed, this bug can be caught in junit test by trying to access a non-existent file in either /logs or /static directories. In other words, whether the tested file exists or not doesn't matter.

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Attachment: 4282_20081103.patch

4282_20081103.patch: filter all urls under "/logs/" and "/static/".

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

      Component/s:     (was: dfs)
         Priority: Blocker  (was: Major)
    Fix Version/s:     (was: 0.19.1)
                   0.19.0
     Hadoop Flags: [Reviewed]

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: 4282_20081103.patch, 4282_20081110.patch, 4282_20081110_0.19.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Attachment: 4282_20081110_0.19.patch

4282_20081110_0.19.patch: for 0.19

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch, 4282_20081110.patch, 4282_20081110_0.19.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645966#action_12645966 ] 

Hadoop QA commented on HADOOP-4282:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393277/4282_20081103.patch
  against trunk revision 712344.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3555/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3555/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3555/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3555/console

This message is automatically generated.

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Status: Patch Available  (was: Open)

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645042#action_12645042 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4282:
------------------------------------------------

> Your patch effectively changes the semantics of addFilter to that of addGlobalFilter in the current 0.20 trunk...

addFilter only filter user facing urls which are defined in HADOOP-3854.  For example, fsck servlet is not filtered as shown in the unit test.  Could you check the patch again?

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Fix Version/s: 0.19.1
         Assignee: Tsz Wo (Nicholas), SZE

As pointed out in HADOOP-3854, all files under "/logs/" and "/static/" should be filtered.  So the bug can be fixed by correcting the path mapping.

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Attachment: 4282_20081110.patch

4282_20081110.patch: changed the log message.

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch, 4282_20081110.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Affects Version/s:     (was: 0.18.1)
                       0.19.0

HADOOP-3854 is committed 0.19.  So the affects version should be 0.19

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-4282:
-------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: 4282_20081103.patch, 4282_20081110.patch, 4282_20081110_0.19.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and "/static/*" are supposed to be filtered. However, files in those directories can be retrieved without triggering my configured filter. The corresponding junit test didn't catch the bug for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did, it might still fail to catch the bug, since according to my observation, only when accessing existent files my filter is bypassed. When accessing non-existent files (which is what the junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.