You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/12/03 07:46:06 UTC
[GitHub] [dubbo] codecov-io commented on issue #5418: Use xxUtils method make code simple

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=h1) Report
> Merging [#5418](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/cd582c5c036a92296b5fbf844f44c1c67ae26e76?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `33.33%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5418/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #5418      +/-   ##
============================================
+ Coverage     61.18%   61.19%   +<.01%     
+ Complexity      424      422       -2     
============================================
  Files           919      919              
  Lines         37488    37488              
  Branches       5461     5461              
============================================
+ Hits          22938    22940       +2     
- Misses        12041    12042       +1     
+ Partials       2509     2506       -3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `77.9% <33.33%> (-2.63%)` | `0 <0> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0%> (-7.96%)` | `19% <0%> (-2%)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `65.9% <0%> (-2.28%)` | `0% <0%> (ø)` | |
| [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `63.1% <0%> (+0.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `89.71% <0%> (+1.86%)` | `16% <0%> (ø)` | :arrow_down: |
| [...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvcmVzdC9SZXN0UHJvdG9jb2wuamF2YQ==) | `71.31% <0%> (+3.1%)` | `0% <0%> (ø)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `69.09% <0%> (+3.63%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (+4.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/dubbo/common/threadpool/ThreadlessExecutor.java](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9UaHJlYWRsZXNzRXhlY3V0b3IuamF2YQ==) | `61.11% <0%> (+5.55%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo/pull/5418/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=footer). Last update [cd582c5...651f3a9](https://codecov.io/gh/apache/dubbo/pull/5418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5418 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org