You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/01 19:26:28 UTC

[GitHub] [druid] vogievetsky commented on a change in pull request #9567: fix global filter input

vogievetsky commented on a change in pull request #9567: fix global filter input
URL: https://github.com/apache/druid/pull/9567#discussion_r401855581
 
 

 ##########
 File path: web-console/src/views/load-data-view/load-data-view.tsx
 ##########
 @@ -2116,7 +2123,12 @@ export class LoadDataView extends React.PureComponent<LoadDataViewProps, LoadDat
         <FormGroup>
           <Button
             text={`${hasGlobalFilter ? 'Edit' : 'Add'} global filter`}
-            onClick={() => this.setState({ showGlobalFilter: true })}
+            onClick={() =>
+              this.setState({
+                showGlobalFilter: true,
+                newFilterValue: deepGet(spec, 'spec.dataSchema.transformSpec.filter'),
 
 Review comment:
   you need to set this to `restFilter` from `const { restFilter } = splitFilter`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org