You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/26 06:18:33 UTC

[GitHub] [flink] Airblader commented on a change in pull request #16585: [FLINK-23482][table] Simplify BlinkExecutorFactory stack

Airblader commented on a change in pull request #16585:
URL: https://github.com/apache/flink/pull/16585#discussion_r676317629



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/DefaultExecutor.java
##########
@@ -55,7 +81,20 @@ public JobClient executeAsync(Pipeline pipeline) throws Exception {
         return executionEnvironment.executeAsync((StreamGraph) pipeline);
     }
 
-    protected String getNonEmptyJobName(String jobName) {
+    private StreamGraph createBatchGraph(

Review comment:
       Is there any reason why we don't push this logic (createBatch* vs createStreaming*) down into `ExecutorUtils`, given that everything we call already lives there as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org