You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/01 03:57:30 UTC

[GitHub] [rocketmq] cserwen commented on a change in pull request #3904: [#3903] Add topic validation, forbid sending message to system topic

cserwen commented on a change in pull request #3904:
URL: https://github.com/apache/rocketmq/pull/3904#discussion_r816426143



##########
File path: client/src/main/java/org/apache/rocketmq/client/Validators.java
##########
@@ -60,6 +60,7 @@ public static void checkMessage(Message msg, DefaultMQProducer defaultMQProducer
         // topic
         Validators.checkTopic(msg.getTopic());
         Validators.isNotAllowedSendTopic(msg.getTopic());
+        Validators.isSystemTopic(msg.getTopic());

Review comment:
       This may affect the sending of trace messages. 
   https://github.com/apache/rocketmq/blob/7281b5d9a0db15e5ec1ab9e3444091e7022f65fb/client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java#L386




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org