[GitHub] [incubator-doris] compiletheworld commented on a diff in pull request #9815: [chore] fix some compatible problems on old linux distributions

[GitBox <gi...@apache.org>]

compiletheworld commented on code in PR #9815:
URL: https://github.com/apache/incubator-doris/pull/9815#discussion_r885691066


##########
thirdparty/build-thirdparty.sh:
##########
@@ -312,14 +312,17 @@ build_protobuf() {
     LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc -Wl,--undefined=pthread_create" \
     ./configure --prefix=${TP_INSTALL_DIR} --disable-shared --enable-static --with-zlib=${TP_INSTALL_DIR}/include
 
-    # ATTN: If protoc is built fully statically with clang-14 on ubuntu,
-    #       it may core dump when parse some protobuf source files.
-    #       The root cause remains unknown, but it is possibly related glibc...
-    #       And, we don't actually need to be that static,
-    #       dyn-linking to glibc and etc. is OK
-    # cd src
-    # sed -i 's/^AM_LDFLAGS\(.*\)$/AM_LDFLAGS\1 -all-static/' Makefile
-    # cd -
+    # ATTN: If protoc is not built fully statically the linktime libc may newer than runtime.

Review Comment:
   Would you please create an issue associated with this pull request?
   I would like to know the dyn-link info of protoc in your env., info like
   
   1. `which ld`
   2. `ldd protoc`
   3. `ldd --version`
   
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org