You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2014/10/09 00:18:35 UTC
[1/5] git commit: Add configuration value to control
AmqpJmsObjectMessage creation using serialized or AMQP types.
Repository: qpid-jms
Updated Branches:
refs/heads/master ee5042c14 -> 803400254
Add configuration value to control AmqpJmsObjectMessage creation using
serialized or AMQP types.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/73fb97a8
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/73fb97a8
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/73fb97a8
Branch: refs/heads/master
Commit: 73fb97a87ffd9cde8c3cef724a7d91ba4571a93b
Parents: ee5042c
Author: Timothy Bish <ta...@gmail.com>
Authored: Wed Oct 8 16:57:17 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Wed Oct 8 16:57:17 2014 -0400
----------------------------------------------------------------------
.../qpid/jms/provider/amqp/AmqpConnection.java | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/73fb97a8/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnection.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnection.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnection.java
index 20aab19..e53d5da 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnection.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnection.java
@@ -55,6 +55,7 @@ public class AmqpConnection extends AbstractAmqpResource<JmsConnectionInfo, Conn
private String tempQueuePrefix;
private String tempTopicPrefix;
+ private boolean objectMessageUsesAmqpTypes = false;
private boolean anonymousProducerCache = false;
private int anonymousProducerCacheSize = 10;
@@ -304,6 +305,24 @@ public class AmqpConnection extends AbstractAmqpResource<JmsConnectionInfo, Conn
}
/**
+ * @return true if new ObjectMessage instance should default to using AMQP Typed bodies.
+ */
+ public boolean isObjectMessageUsesAmqpTypes() {
+ return objectMessageUsesAmqpTypes;
+ }
+
+ /**
+ * Configures the body type used in ObjectMessage instances that are sent from
+ * this connection.
+ *
+ * @param objectMessageUsesAmqpTypes
+ * the objectMessageUsesAmqpTypes value to set.
+ */
+ public void setObjectMessageUsesAmqpTypes(boolean objectMessageUsesAmqpTypes) {
+ this.objectMessageUsesAmqpTypes = objectMessageUsesAmqpTypes;
+ }
+
+ /**
* @return the AMQP based JmsMessageFactory for this Connection.
*/
public AmqpJmsMessageFactory getAmqpMessageFactory() {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[4/5] git commit: Fix isEmpty method.
Posted by ta...@apache.org.
Fix isEmpty method.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/38f87370
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/38f87370
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/38f87370
Branch: refs/heads/master
Commit: 38f8737087c06d56bef69d2562fa48b8749dce0d
Parents: 3a85add
Author: Timothy Bish <ta...@gmail.com>
Authored: Wed Oct 8 18:11:32 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Wed Oct 8 18:11:32 2014 -0400
----------------------------------------------------------------------
.../qpid/jms/provider/amqp/message/AmqpJmsBytesMessageFacade.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/38f87370/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsBytesMessageFacade.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsBytesMessageFacade.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsBytesMessageFacade.java
index 7ab8d4a..d428a0f 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsBytesMessageFacade.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsBytesMessageFacade.java
@@ -104,7 +104,7 @@ public class AmqpJmsBytesMessageFacade extends AmqpJmsMessageFacade implements J
@Override
public boolean isEmpty() {
Binary payload = getBinaryFromBody();
- return payload != null && payload.getLength() > 0;
+ return payload == null || payload.getLength() == 0;
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[5/5] git commit: Test coverage of AmqpJmsMessageFactory.
Posted by ta...@apache.org.
Test coverage of AmqpJmsMessageFactory.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/80340025
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/80340025
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/80340025
Branch: refs/heads/master
Commit: 803400254918a33bee8fe50bcf8a5d439afd2e8b
Parents: 38f8737
Author: Timothy Bish <ta...@gmail.com>
Authored: Wed Oct 8 18:18:26 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Wed Oct 8 18:18:26 2014 -0400
----------------------------------------------------------------------
.../amqp/message/AmqpJmsMessageFactoryTest.java | 205 +++++++++++++++++++
1 file changed, 205 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/80340025/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactoryTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactoryTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactoryTest.java
new file mode 100644
index 0000000..70d8fd0
--- /dev/null
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactoryTest.java
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.qpid.jms.provider.amqp.message;
+
+import static org.apache.qpid.jms.provider.amqp.message.AmqpMessageSupport.JMS_BYTES_MESSAGE;
+import static org.apache.qpid.jms.provider.amqp.message.AmqpMessageSupport.JMS_MAP_MESSAGE;
+import static org.apache.qpid.jms.provider.amqp.message.AmqpMessageSupport.JMS_MESSAGE;
+import static org.apache.qpid.jms.provider.amqp.message.AmqpMessageSupport.JMS_OBJECT_MESSAGE;
+import static org.apache.qpid.jms.provider.amqp.message.AmqpMessageSupport.JMS_STREAM_MESSAGE;
+import static org.apache.qpid.jms.provider.amqp.message.AmqpMessageSupport.JMS_TEXT_MESSAGE;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.io.Serializable;
+import java.util.ArrayList;
+
+import javax.jms.JMSException;
+
+import org.apache.qpid.jms.message.JmsBytesMessage;
+import org.apache.qpid.jms.message.JmsMapMessage;
+import org.apache.qpid.jms.message.JmsMessage;
+import org.apache.qpid.jms.message.JmsObjectMessage;
+import org.apache.qpid.jms.message.JmsStreamMessage;
+import org.apache.qpid.jms.message.JmsTextMessage;
+import org.apache.qpid.jms.message.facade.JmsBytesMessageFacade;
+import org.apache.qpid.jms.message.facade.JmsMapMessageFacade;
+import org.apache.qpid.jms.message.facade.JmsMessageFacade;
+import org.apache.qpid.jms.message.facade.JmsObjectMessageFacade;
+import org.apache.qpid.jms.message.facade.JmsStreamMessageFacade;
+import org.apache.qpid.jms.message.facade.JmsTextMessageFacade;
+import org.apache.qpid.jms.provider.amqp.AmqpConnection;
+import org.apache.qpid.jms.test.QpidJmsTestCase;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+/**
+ * Tests for the AMQP JMS Message Factory class.
+ */
+public class AmqpJmsMessageFactoryTest extends QpidJmsTestCase {
+
+ @Test
+ public void testAmqpJmsMessageFactoryAmqpConnection() {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ assertNotNull(factory.getAmqpConnection());
+ }
+
+ @Test
+ public void testCreateMessage() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsMessage message = factory.createMessage();
+ JmsMessageFacade facade = message.getFacade();
+ assertTrue(facade instanceof AmqpJmsMessageFacade);
+ AmqpJmsMessageFacade amqpMessage = (AmqpJmsMessageFacade) facade;
+
+ assertEquals(JMS_MESSAGE, amqpMessage.getJmsMsgType());
+ }
+
+ @Test
+ public void testCreateTextMessage() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsTextMessage message = factory.createTextMessage();
+ JmsTextMessageFacade facade = (JmsTextMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsTextMessageFacade);
+ AmqpJmsTextMessageFacade amqpMessage = (AmqpJmsTextMessageFacade) facade;
+
+ assertEquals(JMS_TEXT_MESSAGE, amqpMessage.getJmsMsgType());
+ assertNull(amqpMessage.getText());
+ }
+
+ @Test
+ public void testCreateTextMessageString() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsTextMessage message = factory.createTextMessage("SomeValue");
+ JmsTextMessageFacade facade = (JmsTextMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsTextMessageFacade);
+ AmqpJmsTextMessageFacade amqpMessage = (AmqpJmsTextMessageFacade) facade;
+
+ assertEquals(JMS_TEXT_MESSAGE, amqpMessage.getJmsMsgType());
+ assertEquals("SomeValue", amqpMessage.getText());
+ }
+
+ @Test
+ public void testCreateBytesMessage() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsBytesMessage message = factory.createBytesMessage();
+ JmsBytesMessageFacade facade = (JmsBytesMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsBytesMessageFacade);
+ AmqpJmsBytesMessageFacade amqpMessage = (AmqpJmsBytesMessageFacade) facade;
+
+ assertEquals(JMS_BYTES_MESSAGE, amqpMessage.getJmsMsgType());
+ assertTrue(amqpMessage.isEmpty());
+ }
+
+ @Test
+ public void testCreateMapMessage() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsMapMessage message = factory.createMapMessage();
+ JmsMapMessageFacade facade = (JmsMapMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsMapMessageFacade);
+ AmqpJmsMapMessageFacade amqpMessage = (AmqpJmsMapMessageFacade) facade;
+
+ assertEquals(JMS_MAP_MESSAGE, amqpMessage.getJmsMsgType());
+ assertTrue(amqpMessage.isEmpty());
+ }
+
+ @Test
+ public void testCreateStreamMessage() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsStreamMessage message = factory.createStreamMessage();
+ JmsStreamMessageFacade facade = (JmsStreamMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsStreamMessageFacade);
+ AmqpJmsStreamMessageFacade amqpMessage = (AmqpJmsStreamMessageFacade) facade;
+
+ assertEquals(JMS_STREAM_MESSAGE, amqpMessage.getJmsMsgType());
+ assertTrue(amqpMessage.isEmpty());
+ }
+
+ @Test
+ public void testCreateObjectMessage() throws JMSException, ClassNotFoundException, IOException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsObjectMessage message = factory.createObjectMessage();
+ JmsObjectMessageFacade facade = (JmsObjectMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsObjectMessageFacade);
+ AmqpJmsObjectMessageFacade amqpMessage = (AmqpJmsObjectMessageFacade) facade;
+
+ assertEquals(JMS_OBJECT_MESSAGE, amqpMessage.getJmsMsgType());
+ assertFalse(amqpMessage.isAmqpTypedEncoding());
+ assertNull(amqpMessage.getObject());
+ }
+
+ @Test
+ public void testCreateObjectMessageHonorsAmqpTypeConfig() throws JMSException, ClassNotFoundException, IOException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnectionAmqpTypes());
+ JmsObjectMessage message = factory.createObjectMessage();
+ JmsObjectMessageFacade facade = (JmsObjectMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsObjectMessageFacade);
+ AmqpJmsObjectMessageFacade amqpMessage = (AmqpJmsObjectMessageFacade) facade;
+
+ assertEquals(JMS_OBJECT_MESSAGE, amqpMessage.getJmsMsgType());
+ assertTrue(amqpMessage.isAmqpTypedEncoding());
+ assertNull(amqpMessage.getObject());
+ }
+
+ @Test
+ public void testCreateObjectMessageSerializable() throws JMSException, ClassNotFoundException, IOException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ JmsObjectMessage message = factory.createObjectMessage(new ArrayList<Boolean>());
+ JmsObjectMessageFacade facade = (JmsObjectMessageFacade) message.getFacade();
+ assertTrue(facade instanceof AmqpJmsObjectMessageFacade);
+ AmqpJmsObjectMessageFacade amqpMessage = (AmqpJmsObjectMessageFacade) facade;
+
+ assertEquals(JMS_OBJECT_MESSAGE, amqpMessage.getJmsMsgType());
+ assertFalse(amqpMessage.isAmqpTypedEncoding());
+ assertNotNull(amqpMessage.getObject());
+ }
+
+ @Test
+ public void testCreateObjectMessageWithBadTypeThrowsJMSException() throws JMSException {
+ AmqpJmsMessageFactory factory = new AmqpJmsMessageFactory(createMockAmqpConnection());
+ try {
+ factory.createObjectMessage(new NotSerializable());
+ fail("Should have thrown an exception");
+ } catch (JMSException e) {
+ }
+ }
+
+ private class NotSerializable implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ private void writeObject(ObjectOutputStream stream) throws IOException {
+ throw new IOException();
+ }
+ }
+
+ private AmqpConnection createMockAmqpConnectionAmqpTypes() {
+ AmqpConnection connection = Mockito.mock(AmqpConnection.class);
+ Mockito.when(connection.isObjectMessageUsesAmqpTypes()).thenReturn(true);
+ return connection;
+ }
+
+ private AmqpConnection createMockAmqpConnection() {
+ return Mockito.mock(AmqpConnection.class);
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[2/5] git commit: Update JavaDoc comment.
Posted by ta...@apache.org.
Update JavaDoc comment.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/1cfb7564
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/1cfb7564
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/1cfb7564
Branch: refs/heads/master
Commit: 1cfb756495e0d35ff476ef219f202245ba9db77e
Parents: 73fb97a
Author: Timothy Bish <ta...@gmail.com>
Authored: Wed Oct 8 16:59:27 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Wed Oct 8 16:59:27 2014 -0400
----------------------------------------------------------------------
.../qpid/jms/provider/amqp/message/AmqpJmsObjectMessageFacade.java | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/1cfb7564/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsObjectMessageFacade.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsObjectMessageFacade.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsObjectMessageFacade.java
index 6791086..894ff3a 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsObjectMessageFacade.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsObjectMessageFacade.java
@@ -43,6 +43,8 @@ public class AmqpJmsObjectMessageFacade extends AmqpJmsMessageFacade implements
*
* @param connection
* the AmqpConnection that under which this facade was created.
+ * @param isAmqpTypeEncoded
+ * controls the type used to encode the body.
*/
public AmqpJmsObjectMessageFacade(AmqpConnection connection, boolean isAmqpTypeEncoded) {
super(connection);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[3/5] git commit: Make the object immutable and read the encoding
type for new Object mesage types from the parent connection.
Posted by ta...@apache.org.
Make the object immutable and read the encoding type for new Object
mesage types from the parent connection.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/3a85addd
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/3a85addd
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/3a85addd
Branch: refs/heads/master
Commit: 3a85adddb4c44f63b520203ab81e906171c9db07
Parents: 1cfb756
Author: Timothy Bish <ta...@gmail.com>
Authored: Wed Oct 8 17:00:01 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Wed Oct 8 17:00:01 2014 -0400
----------------------------------------------------------------------
.../provider/amqp/message/AmqpJmsMessageFactory.java | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/3a85addd/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
index 214d8e4..02d6f3b 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
@@ -41,10 +41,7 @@ import org.apache.qpid.jms.provider.amqp.AmqpConnection;
*/
public class AmqpJmsMessageFactory implements JmsMessageFactory {
- private AmqpConnection connection;
-
- public AmqpJmsMessageFactory() {
- }
+ private final AmqpConnection connection;
public AmqpJmsMessageFactory(AmqpConnection connection) {
this.connection = connection;
@@ -54,10 +51,6 @@ public class AmqpJmsMessageFactory implements JmsMessageFactory {
return this.connection;
}
- public void setAmqpConnection(AmqpConnection connection) {
- this.connection = connection;
- }
-
@Override
public JmsMessage createMessage() throws JMSException {
return new JmsMessage(new AmqpJmsMessageFacade(connection));
@@ -102,8 +95,7 @@ public class AmqpJmsMessageFactory implements JmsMessageFactory {
@Override
public JmsObjectMessage createObjectMessage(Serializable payload) throws JMSException {
- // TODO Implement [Connection?] configuration to control default delegate type?
- JmsObjectMessageFacade facade = new AmqpJmsObjectMessageFacade(connection, false);
+ JmsObjectMessageFacade facade = new AmqpJmsObjectMessageFacade(connection, connection.isObjectMessageUsesAmqpTypes());
if (payload != null) {
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org