You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by dw...@apache.org on 2010/10/13 19:42:39 UTC

svn commit: r1022210 - in /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence: fields/ generationtype/

Author: dwoods
Date: Wed Oct 13 17:42:37 2010
New Revision: 1022210

URL: http://svn.apache.org/viewvc?rev=1022210&view=rev
Log:
make sure tests close EMs

Modified:
    openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/fields/TestByteArray.java
    openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestEntityWithGeneratedValueAndPostPersist.java
    openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestMultipleSchemaNames.java
    openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestTableGenerator.java

Modified: openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/fields/TestByteArray.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/fields/TestByteArray.java?rev=1022210&r1=1022209&r2=1022210&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/fields/TestByteArray.java (original)
+++ openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/fields/TestByteArray.java Wed Oct 13 17:42:37 2010
@@ -83,5 +83,7 @@ public class TestByteArray extends Singl
         holder = em.find(ByteArrayHolder.class, holder.getTaskId());
         String baFromH = new String(holder.getTkiid());
         assertEquals(new String (ba), baFromH);
+        closeEM(em);
+        closeEM(em2);
     }
 }

Modified: openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestEntityWithGeneratedValueAndPostPersist.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestEntityWithGeneratedValueAndPostPersist.java?rev=1022210&r1=1022209&r2=1022210&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestEntityWithGeneratedValueAndPostPersist.java (original)
+++ openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestEntityWithGeneratedValueAndPostPersist.java Wed Oct 13 17:42:37 2010
@@ -62,6 +62,7 @@ public class TestEntityWithGeneratedValu
         // check the value captured by the PostPersist callback
         assertEquals("Entity's current value does not match value captured " +
         		"in postPersist", pc.getBingo(), cache);
+        closeEM(em);
     }
     
     public void testValueCapturedInPostPersistAfterFlush() {
@@ -90,6 +91,7 @@ public class TestEntityWithGeneratedValu
         // check the value captured by the PostPersist callback
         assertEquals("Entity's current value does not match value captured " +
         		"in postPersist", pc.getBingo(), cache);
+        closeEM(em);
     }
     
     private EntityManager getEM() {

Modified: openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestMultipleSchemaNames.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestMultipleSchemaNames.java?rev=1022210&r1=1022209&r2=1022210&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestMultipleSchemaNames.java (original)
+++ openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestMultipleSchemaNames.java Wed Oct 13 17:42:37 2010
@@ -443,6 +443,7 @@ public class TestMultipleSchemaNames ext
                 em.getTransaction().rollback();
             }
         }
+        closeEM(em);
         closeEMF(tempEmf);
     }
 

Modified: openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestTableGenerator.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestTableGenerator.java?rev=1022210&r1=1022209&r2=1022210&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestTableGenerator.java (original)
+++ openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestTableGenerator.java Wed Oct 13 17:42:37 2010
@@ -43,5 +43,6 @@ public class TestTableGenerator extends 
         em.refresh(dog);
 
         assertEquals(20, dog.getId());
+        closeEM(em);
     }
 }